Remove deviation gnoi_fabric_component_reboot_unsupported #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deviation gnoi_fabric_component_reboot_unsupported for Juniper in metadata.textproto
Pull Request Functional Test Report for #2139 / 731187cVirtual Devices
Hardware Devices
|
|
/gcbrun |
sachendras
previously approved these changes
Oct 5, 2023
Pull Request Test Coverage Report for Build 6418794428
💛 - Coveralls |
greg-dennis
previously approved these changes
Oct 5, 2023
|
Since this test is looking for the existence of removable fabric/linecards and would fail if none exists, FFF chassis w/o removable fabric cards and Linecards will always fail this test. Hence please skip the tests for removable fabric and for removable line cards if the boolean /components/component/state/removable == TRUE. |
sachendras
previously approved these changes
Oct 6, 2023
|
To resolve conflicts issue, close current pull request. It will be tracked via new pull request: |
nicjiang2023
added a commit
to nicjiang2023/featureprofiles
that referenced
this pull request
Oct 8, 2023
…rio. Updated script as per comment in pull request: openconfig#2139
arulkumarsekar
added a commit
that referenced
this pull request
Nov 3, 2023
…#2234) * Skip the test for no removable fabric card and line cards found scenario. Updated script as per comment in pull request: #2139 * Add arg.NumLinecards check * Added a new arg NumFabrics and used args.NumFabrics for checking in TestFabricReboot --------- Co-authored-by: Arul Kumar Sekar <[email protected]>
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Nov 3, 2023
…openconfig#2234) * Skip the test for no removable fabric card and line cards found scenario. Updated script as per comment in pull request: openconfig#2139 * Add arg.NumLinecards check * Added a new arg NumFabrics and used args.NumFabrics for checking in TestFabricReboot --------- Co-authored-by: Arul Kumar Sekar <[email protected]>
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Nov 3, 2023
…openconfig#2234) * Skip the test for no removable fabric card and line cards found scenario. Updated script as per comment in pull request: openconfig#2139 * Add arg.NumLinecards check * Added a new arg NumFabrics and used args.NumFabrics for checking in TestFabricReboot --------- Co-authored-by: Arul Kumar Sekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deviation gnoi_fabric_component_reboot_unsupported for Juniper in metadata.textproto