Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gNMI-1.13: New deviation for transceiver thresholds #2122

Merged
merged 9 commits into from
Sep 15, 2023

Conversation

sgirishj
Copy link
Contributor

Adding a new deviation for unsupported 'thresholds' container under transceiver component.

@sgirishj sgirishj requested review from a team as code owners September 13, 2023 17:24
@OpenConfigBot
Copy link

OpenConfigBot commented Sep 13, 2023

sachendras
sachendras previously approved these changes Sep 14, 2023
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the changes to metadata.proto to go along with this deviation?

@sachendras
Copy link
Contributor

Where are the changes to metadata.proto to go along with this deviation?

Is this not the one? https://screenshot.googleplex.com/6wgdxuxQs67cxPS

@sgirishj
Copy link
Contributor Author

Where are the changes to metadata.proto to go along with this deviation?

Had left it out by mistake; just pushed it in. Thanks!

@arulkumarsekar arulkumarsekar merged commit d0f7871 into openconfig:main Sep 15, 2023
10 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Sep 15, 2023
* gNMI-1.13: New deviation for unsupported threshold container under transceiver component

* Committing metadata.proto; had missed this in the earlier commit.

---------

Co-authored-by: nicjiang2023 <[email protected]>
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Sep 25, 2023
* gNMI-1.13: New deviation for unsupported threshold container under transceiver component

* Committing metadata.proto; had missed this in the earlier commit.

---------

Co-authored-by: nicjiang2023 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants