TE-3.7_otg_mac_fix #2080

manan-patel · 2023-08-31T19:04:35Z

Mac entries were removed in PR
https://github.com/openconfig/featureprofiles/pull/1855/files#diff-8acaeb616dcb7318148a8e7c202fb4ffc7e4c7aaf98c5a59a9ed34d410583dfd

OpenConfigBot · 2023-08-31T19:04:48Z

Pull Request Functional Test Report for #2080 / `5ed03e9`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-3.7: Base Hierarchical NHG Update
Cisco 8000E		TE-3.7: Base Hierarchical NHG Update
Cisco XRd		TE-3.7: Base Hierarchical NHG Update
Juniper cPTX		TE-3.7: Base Hierarchical NHG Update
Nokia SR Linux		TE-3.7: Base Hierarchical NHG Update
Openconfig Lemming		TE-3.7: Base Hierarchical NHG Update

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TE-3.7: Base Hierarchical NHG Update
Cisco 8808		TE-3.7: Base Hierarchical NHG Update
Juniper PTX10008		TE-3.7: Base Hierarchical NHG Update
Nokia 7250 IXR-10e		TE-3.7: Base Hierarchical NHG Update

Help

jasdeep-hundal

atePort4 also needs a MAC address set

jasdeep-hundal

@manan-patel : The condition here is inverted as compared to the ATE version: https://github.com/openconfig/featureprofiles/pull/2080/files#diff-8acaeb616dcb7318148a8e7c202fb4ffc7e4c7aaf98c5a59a9ed34d410583dfdL485

manan-patel

I have updated the deviation to match with ATE tc. It should be skipped for all the vendors. It will fail for us due to traffic issue which keysights folks needs to help triage.

feature/gribi/otg_tests/base_hierarchical_nhg_update/base_hierarchical_nhg_update_test.go

* Delete deprecated ATE version of the P4RT tests * Delete deprecated ATE version of the QoS tests

* Create route-reflector-test Proposed test addresses requirements in the internal bug b/287237486 Validates: - BGP RR capability where IBGP peering address is learnt over IS-IS - OC leaves that capture BGP transport session attributes like local-address, peer-type - Ensure supported-capabilites leaf functionality * Update route-reflector-test * Rename feature/bgp/route-reflector-test to feature/bgp/routereflector/route-reflector-test Moving the test in routereflector directory * Update route-reflector-test * Update route-reflector-test * Update route-reflector-test * Update route-reflector-test * Rename route-reflector-test to README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: Benson Schliesser <[email protected]>

* fix test expectation * fix isis interface passive test to use session library * Fix QOS tests for Arista

* Migrate off remaining deprecated raw api uses * feedback

* Add gRIBI MPLS compliance test basics. * (A) feature/gribi/mplsutil/... - Add utilities for gRIBI MPLS compliance testing. * (A) feature/gribi/otg_tests/mpls_compliance/... - Add initial gRIBI MPLS compliance test. * Remove shadow `baseLabel` definition.

* DP-1.2: Adding test support for Nokia 1. Adding testNokiaClassifierConfig and testNokiaSchedulerPoliciesConfig to cover script scenario for Nokia 2. Adding function (SetForwardingGroupWithFabricPriority) to configure ForwardingGroup with Fabric-priority in qoscfg.go * Updating queue-name based on commonTrafficQueueNames based openconfig/entity-naming#24 * Adding buffer-allocation configuration for maxBurstSize. * Consolidating buffer-allocation config. * Replacing fabric-priority configuration with Queue-id as discussed in b/297188157 * Validating priority state only when configured strict. --------- Co-authored-by: Sergey Fomin <[email protected]>

* DP-1.4: Adding test support for Nokia Following changes are made in this PR - 1. Updating deviations in metadata file 2. Updating test script to support Nokia 3. Adding function (SetForwardingGroupWithFabricPriority) to configure ForwardingGroup with Fabric-priority in qoscfg.go "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." Co-authored-by: Krishna Bovilla <[email protected]> * Replacing fabric-priority configuration with queue-id as discussed in b/297188157 "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." --------- Co-authored-by: Krishna Bovilla <[email protected]> Co-authored-by: Sergey Fomin <[email protected]>

As part of PR-2026 ,part of config was removed by mistake and corrected it. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

…2125)

This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an as is basis without any warranties of any kind. Co-authored-by: Sergey Fomin <[email protected]>

jasdeep-hundal

We should rewrite the getLossPct function slightly because floating point math can get weird and we're sometimes seeing an incorrect non-zero output here. Casting should be deferred until the final computation, which should then become 100 * (float32(lostPackets) / float32(txPackets))

A few more changes requested in the comments as well.

feature/gribi/otg_tests/base_hierarchical_nhg_update/base_hierarchical_nhg_update_test.go

author manan-patel <[email protected]> 1693508622 -0400 committer manan-patel <[email protected]> 1695396051 -0400 added MACs added mac for port4 updated otg pushconfig call location set GRIBIMACOverrideWithStaticARP condition same as counter ATE tc Add a few documentation pointers back to Ondatra. (openconfig#2112) Update RT-1.20 to RT-1.24 (openconfig#2121) BGP route-reflector-at-scale-test (openconfig#1756) * Create route-reflector-test Proposed test addresses requirements in the internal bug b/287237486 Validates: - BGP RR capability where IBGP peering address is learnt over IS-IS - OC leaves that capture BGP transport session attributes like local-address, peer-type - Ensure supported-capabilites leaf functionality * Update route-reflector-test * Rename feature/bgp/route-reflector-test to feature/bgp/routereflector/route-reflector-test Moving the test in routereflector directory * Update route-reflector-test * Update route-reflector-test * Update route-reflector-test * Update route-reflector-test * Rename route-reflector-test to README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: Benson Schliesser <[email protected]> QOS changes (openconfig#2111) * fix test expectation * fix isis interface passive test to use session library * Fix QOS tests for Arista Migrate off remaining deprecated raw api uses (openconfig#2115) * Migrate off remaining deprecated raw api uses * feedback Add gRIBI MPLS compliance test basics. (openconfig#2124) * Add gRIBI MPLS compliance test basics. * (A) feature/gribi/mplsutil/... - Add utilities for gRIBI MPLS compliance testing. * (A) feature/gribi/otg_tests/mpls_compliance/... - Add initial gRIBI MPLS compliance test. * Remove shadow `baseLabel` definition. DP-1.2: Adding test support for Nokia (openconfig#2001) * DP-1.2: Adding test support for Nokia 1. Adding testNokiaClassifierConfig and testNokiaSchedulerPoliciesConfig to cover script scenario for Nokia 2. Adding function (SetForwardingGroupWithFabricPriority) to configure ForwardingGroup with Fabric-priority in qoscfg.go * Updating queue-name based on commonTrafficQueueNames based openconfig/entity-naming#24 * Adding buffer-allocation configuration for maxBurstSize. * Consolidating buffer-allocation config. * Replacing fabric-priority configuration with Queue-id as discussed in b/297188157 * Validating priority state only when configured strict. --------- Co-authored-by: Sergey Fomin <[email protected]> DP-1.4: Adding test support for Nokia (openconfig#2023) * DP-1.4: Adding test support for Nokia Following changes are made in this PR - 1. Updating deviations in metadata file 2. Updating test script to support Nokia 3. Adding function (SetForwardingGroupWithFabricPriority) to configure ForwardingGroup with Fabric-priority in qoscfg.go "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." Co-authored-by: Krishna Bovilla <[email protected]> * Replacing fabric-priority configuration with queue-id as discussed in b/297188157 "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." --------- Co-authored-by: Krishna Bovilla <[email protected]> Co-authored-by: Sergey Fomin <[email protected]> Fix new use of deprecated raw API (openconfig#2130) DP-1.14: Fixing error in forwarding group config (openconfig#2123) As part of PR-2026 ,part of config was removed by mistake and corrected it. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." Adding support for vendor ARISTA in Core file check test (openconfig#2125) adding case insensitive check for mac (openconfig#1635) This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an as is basis without any warranties of any kind. Co-authored-by: Sergey Fomin <[email protected]> incorporated comments incoporated comments rebased

manan-patel · 2023-09-22T15:52:15Z

Raised PR #2172 to fix the CLA CI/CD check failing under current PR

jasdeep-hundal · 2023-09-22T19:02:49Z

Merged in #2172 instead

added MACs

f8cc422

manan-patel requested review from a team as code owners August 31, 2023 19:04

manan-patel requested a review from michaelore August 31, 2023 19:04

manan-patel changed the title ~~added MACs~~ TE-3.7_otg_mac_fix Aug 31, 2023

manan-patel added the cisco-pr label Aug 31, 2023

jasdeep-hundal requested changes Aug 31, 2023

View reviewed changes

manan-patel added 6 commits August 31, 2023 17:14

added mac for port4

b1c9b8c

Merge branch 'main' into TE-3.7_otg_mac_fix

de4d2b9

updated otg pushconfig call location

c8009f7

Merge branch 'main' into TE-3.7_otg_mac_fix

e0a2667

Merge branch 'main' into TE-3.7_otg_mac_fix

a519fd5

Merge branch 'main' into TE-3.7_otg_mac_fix

8fabf9c

jasdeep-hundal self-assigned this Sep 6, 2023

manan-patel added 2 commits September 6, 2023 15:00

Merge branch 'main' into TE-3.7_otg_mac_fix

50d8225

Merge branch 'main' into TE-3.7_otg_mac_fix

fa4e673

jasdeep-hundal requested changes Sep 11, 2023

View reviewed changes

manan-patel added 2 commits September 11, 2023 16:57

Merge branch 'main' into TE-3.7_otg_mac_fix

fa5182d

set GRIBIMACOverrideWithStaticARP condition same as counter ATE tc

a77f638

manan-patel commented Sep 12, 2023

View reviewed changes

jasdeep-hundal requested changes Sep 14, 2023

View reviewed changes

feature/gribi/otg_tests/base_hierarchical_nhg_update/base_hierarchical_nhg_update_test.go Show resolved Hide resolved

feature/gribi/otg_tests/base_hierarchical_nhg_update/base_hierarchical_nhg_update_test.go Outdated Show resolved Hide resolved

greg-dennis and others added 7 commits September 15, 2023 10:23

Add a few documentation pointers back to Ondatra. (openconfig#2112)

820f79d

Delete P4RT/QoS ATE tests (openconfig#2114)

36c1a11

* Delete deprecated ATE version of the P4RT tests * Delete deprecated ATE version of the QoS tests

Update RT-1.20 to RT-1.24 (openconfig#2121)

2cdc884

QOS changes (openconfig#2111)

4f46756

* fix test expectation * fix isis interface passive test to use session library * Fix QOS tests for Arista

Migrate off remaining deprecated raw api uses (openconfig#2115)

0f638ca

* Migrate off remaining deprecated raw api uses * feedback

trathod1 and others added 8 commits September 15, 2023 10:23

Fix new use of deprecated raw API (openconfig#2130)

244447c

Adding support for vendor ARISTA in Core file check test (openconfig#…

5e7f916

…2125)

incorporated comments

83e63c7

rebase

7c689a1

jasdeep-hundal requested changes Sep 19, 2023

View reviewed changes

manan-patel added 4 commits September 22, 2023 10:28

Merge branch 'main' into TE-3.7_otg_mac_fix

52970bb

incoporated comments

2d28609

rebased

2bebee1

manan-patel mentioned this pull request Sep 22, 2023

TE-3.7_otg_ate_fix #2172

Merged

removed unwanted changes

5ed03e9

jasdeep-hundal closed this Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TE-3.7_otg_mac_fix #2080

TE-3.7_otg_mac_fix #2080

manan-patel commented Aug 31, 2023

OpenConfigBot commented Aug 31, 2023 •

edited

Loading

jasdeep-hundal left a comment

jasdeep-hundal left a comment

manan-patel left a comment

jasdeep-hundal left a comment •

edited

Loading

manan-patel commented Sep 22, 2023

jasdeep-hundal commented Sep 22, 2023

TE-3.7_otg_mac_fix #2080

TE-3.7_otg_mac_fix #2080

Conversation

manan-patel commented Aug 31, 2023

OpenConfigBot commented Aug 31, 2023 • edited Loading

Pull Request Functional Test Report for #2080 / 5ed03e9

Virtual Devices

Hardware Devices

jasdeep-hundal left a comment

Choose a reason for hiding this comment

jasdeep-hundal left a comment

Choose a reason for hiding this comment

manan-patel left a comment

Choose a reason for hiding this comment

jasdeep-hundal left a comment • edited Loading

Choose a reason for hiding this comment

manan-patel commented Sep 22, 2023

jasdeep-hundal commented Sep 22, 2023

OpenConfigBot commented Aug 31, 2023 •

edited

Loading

Pull Request Functional Test Report for #2080 / `5ed03e9`

jasdeep-hundal left a comment •

edited

Loading