Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE-9.1 : FIB FAILURE DUE TO HARDWARE RESOURCE EXHAUST #2048

Merged
merged 47 commits into from
Oct 9, 2023

Conversation

cprabha
Copy link
Contributor

@cprabha cprabha commented Aug 22, 2023

Hi,

This PR is Initial Commit for TE-9.1 FIB FAILURE DUE TO HARDWARE RESOURCE EXHAUST.
Resolves : #508

Thanks,
Prabha

@cprabha cprabha requested review from a team as code owners August 22, 2023 03:51
@OpenConfigBot
Copy link

OpenConfigBot commented Aug 22, 2023

@cprabha
Copy link
Contributor Author

cprabha commented Aug 22, 2023

@greg-dennis This test needs to inject 2.5M routes . As per current guidelines in contributing.md none of address blocks can be used to inject 2.5M routes. I have used 20.0.1.1/32. With this static check fails. please could you suggest how to resolve this.

@cprabha cprabha marked this pull request as draft August 23, 2023 22:08
@coveralls
Copy link

coveralls commented Aug 23, 2023

Pull Request Test Coverage Report for Build 6175565869

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.707%

Totals Coverage Status
Change from base Build 6175447171: 0.0%
Covered Lines: 1347
Relevant Lines: 2947

💛 - Coveralls

sachendras
sachendras previously approved these changes Sep 8, 2023
@cprabha
Copy link
Contributor Author

cprabha commented Sep 8, 2023

@greg-dennis This test needs to inject 2.5M routes . As per current guidelines in contributing.md none of address blocks can be used to inject 2.5M routes. I have used 20.0.1.1/32. With this static check fails. please could you suggest how to resolve this.

@greg-dennis , please could you check and help with one more network to use in script to generate 2.5M routes . As of now IP address blocks which are provided in CONTRIBUTING.md does not support 2.5M scale.
There is another test we need similar scale and that needs 4 such IP address groups. . Thank you.

@cprabha cprabha marked this pull request as ready for review September 13, 2023 19:58
@xw-g
Copy link
Collaborator

xw-g commented Sep 27, 2023

@greg-dennis This test needs to inject 2.5M routes . As per current guidelines in contributing.md none of address blocks can be used to inject 2.5M routes. I have used 20.0.1.1/32. With this static check fails. please could you suggest how to resolve this.

@greg-dennis , please could you check and help with one more network to use in script to generate 2.5M routes . As of now IP address blocks which are provided in CONTRIBUTING.md does not support 2.5M scale. There is another test we need similar scale and that needs 4 such IP address groups. . Thank you.

@dplore @liulk Please let us know your thoughts on this restriction

@cprabha how about we use BGP to advertise v6 prefix to use up most of the FIB resourcing, and then injecting gRIBI routes? I think that maybe required much less gRIBI v4 routes. What do you think?

@xw-g Test is already validated with v4 bgp routes and , If we need to code with v6 routes will have to re validate test, which will delay this PR and further more we have not tested FIB behavior with v6 . If any issues observed will cause further delay.

If we get new address block in v4 will help to expediate this PR.

Also couple of other BGP scale tests we have test steps with similar scale and new address block is helpful.

@greg-dennis is it convenient to get one more v4 block? If not, @cprabha I think probably you can do v6 over v4 advertisement as a way to fill up the routing table. Thanks.

@cprabha
Copy link
Contributor Author

cprabha commented Sep 29, 2023

@greg-dennis This test needs to inject 2.5M routes . As per current guidelines in contributing.md none of address blocks can be used to inject 2.5M routes. I have used 20.0.1.1/32. With this static check fails. please could you suggest how to resolve this.

@greg-dennis , please could you check and help with one more network to use in script to generate 2.5M routes . As of now IP address blocks which are provided in CONTRIBUTING.md does not support 2.5M scale. There is another test we need similar scale and that needs 4 such IP address groups. . Thank you.

@dplore @liulk Please let us know your thoughts on this restriction

@cprabha how about we use BGP to advertise v6 prefix to use up most of the FIB resourcing, and then injecting gRIBI routes? I think that maybe required much less gRIBI v4 routes. What do you think?

@xw-g Test is already validated with v4 bgp routes and , If we need to code with v6 routes will have to re validate test, which will delay this PR and further more we have not tested FIB behavior with v6 . If any issues observed will cause further delay.
If we get new address block in v4 will help to expediate this PR.
Also couple of other BGP scale tests we have test steps with similar scale and new address block is helpful.

@greg-dennis is it convenient to get one more v4 block? If not, @cprabha I think probably you can do v6 over v4 advertisement as a way to fill up the routing table. Thanks.

@greg-dennis , @xw-g I have updated script with v6 block and all checks passed. Thanks.

Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one nit

internal/deviations/deviations.go Outdated Show resolved Hide resolved
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Go quality

@arulkumarsekar arulkumarsekar merged commit aeaa2e5 into openconfig:main Oct 9, 2023
10 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Oct 9, 2023
* Initial Commit for TE-9.1

* removed commented code

* Update fib_failed_due_to_hw_res_exhaust_test.go

* Update fib_failed_due_to_hw_res_exhaust_test.go

* Added deviation

* fixing conflicts

* Adding tag

* Adding tag

* fixing fmt issues

* Updated with comments and resolved conflicts

* updated i value

* updated review comments

* changed address block  from v4 to v6

* Addressing review comments

* Addressing review comments

* updated with comments

---------

Co-authored-by: Arul Kumar Sekar <[email protected]>
manan-patel pushed a commit to manan-patel/featureprofiles that referenced this pull request Oct 10, 2023
* Initial Commit for TE-9.1

* removed commented code

* Update fib_failed_due_to_hw_res_exhaust_test.go

* Update fib_failed_due_to_hw_res_exhaust_test.go

* Added deviation

* fixing conflicts

* Adding tag

* Adding tag

* fixing fmt issues

* Updated with comments and resolved conflicts

* updated i value

* updated review comments

* changed address block  from v4 to v6

* Addressing review comments

* Addressing review comments

* updated with comments

---------

Co-authored-by: Arul Kumar Sekar <[email protected]>
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Oct 18, 2023
* Initial Commit for TE-9.1

* removed commented code

* Update fib_failed_due_to_hw_res_exhaust_test.go

* Update fib_failed_due_to_hw_res_exhaust_test.go

* Added deviation

* fixing conflicts

* Adding tag

* Adding tag

* fixing fmt issues

* Updated with comments and resolved conflicts

* updated i value

* updated review comments

* changed address block  from v4 to v6

* Addressing review comments

* Addressing review comments

* updated with comments

---------

Co-authored-by: Arul Kumar Sekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TE-9.1: FIB failure due to hardware resource exhaust
9 participants