TUN-1.3 Interface based IPv4 GRE Encapsulation #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #2005 / 6b2125eVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 9555195923Details
💛 - Coveralls |
Updated SetPrefix with uint32
r4huluk
added
the
new-requirement-pr
sezhang2
reviewed
Jan 3, 2024
| @@ -0,0 +1,482 @@ | |||
| // Copyright 2023 Google LLC | |||
sezhang2
reviewed
Jan 3, 2024
| t.Logf("Flow: %s received packets: %d !", flowName, rxPackets) | ||
| lostPackets := txPackets - rxPackets | ||
| t.Logf("Flow: %s lost packets: %d !", flowName, lostPackets) | ||
| lossPct := lostPackets * 100 / txPackets |
There was a problem hiding this comment.
Replace lossPct with got and set want := 100.0
sezhang2
reviewed
Jan 3, 2024
| initialTunnelOutPkts := make([]uint64, tunnelCount) | ||
| tunnelLoadblanceDiff := tunnelCount * 3 | ||
| interfaceLoadblanceDiff := tolerance | ||
| t.Run("Configure dut with 32 tunnel interface with one ingress and 2 egress interface", func(t *testing.T) { |
There was a problem hiding this comment.
t.Run() will create sub-testcase. There should be no dependency requirement between sub-testcases as you can run any sub-testcase independently. But, your sub-testcases are required to run one by one in fixed order.
sezhang2
reviewed
Jan 3, 2024
| f1v4.Src().Increment().SetStart(peer.IPv4).SetCount(200) | ||
| // V4 destination | ||
| f1v4.Dst().Increment().SetStart(encapInnerDesIpv4Network).SetCount(200) | ||
| // Add L4 protocol |
There was a problem hiding this comment.
Please remove all comments as traffic flow APIs are self-explanatory and commonly used.
sezhang2
reviewed
Jan 3, 2024
| addr := net.ParseIP(address) | ||
| var network net.IP | ||
|
|
||
| // This mask corresponds to a /24 subnet for IPv4. |
There was a problem hiding this comment.
mask is a variable here. /24 is one case. Another call passes 19 as mask value
sezhang2
reviewed
Jan 3, 2024
|
|
||
| networkWithMask := network.String() + "/" + strconv.Itoa(mask) | ||
| networkAlone := network.String() | ||
| //t.Logf("Network address : %s", networkWithMask) |
sezhang2
reviewed
Jan 3, 2024
| hardware_model: "PTX10001-36MR" | ||
| hardware_model: "cptx" | ||
| } | ||
| deviations: { |
There was a problem hiding this comment.
Please mention the bug ID here for new deviations.
We need bugs to track new deviations.
sezhang2
reviewed
Jan 3, 2024
| t.Logf("Push the CLI config:\n%s", config) | ||
|
|
||
| default: | ||
| t.Errorf("Invalid Tunnel endpoint configuration") |
There was a problem hiding this comment.
Make error msg more specific. Something like:
Tunnel endpoint configuration is not defined for dut.Vendor().
sezhang2
previously approved these changes
Jan 3, 2024
sachendras
reviewed
Mar 5, 2024
| - Tunnel source should be able to configure with unnumbered interface address | ||
| - Tunnel Destination | ||
| - Directly on Tunnel interface or Tunnel Group | ||
| - Configure such 32 tunnel interfaces |
There was a problem hiding this comment.
Can you please update this to 2k tunnel endpoints to match w/ the HLD requirements?
|
Please fix README |
|
Also kindly update the brach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TUN-1.3 Interface based IPv4 GRE Encapsulation
Validate the GRE configuration
Configure GRE Tunnel interfaces configuration options - Tunnel source, Tunnel Destination on Tunnel interface
Configure static route with IPv4 NH pointing to Tunnel interfaces
Validate the applied config did not report any errors
Enable the packet capture on ATE ingress port to verify the GRE header of uncapped traffic
Verify the tunnel interfaces counters to confirm the traffic encapsulation
After encapsulation, traffic should be load balanced/hash to all available L3 ECMP or LAG or combination of both features
This resolves 1600