Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RT-1.21: BGP TCP MSS and PMTUD #1910

Merged
merged 49 commits into from
Sep 21, 2023
Merged

RT-1.21: BGP TCP MSS and PMTUD #1910

merged 49 commits into from
Sep 21, 2023

Conversation

cprabha
Copy link
Contributor

@cprabha cprabha commented Jul 19, 2023

Hi,

I have added automation for RT-1.21: BGP TCP MSS and PMTUD .
This will resolve #1591

Thanks,
Prabha

@cprabha cprabha requested review from a team as code owners July 19, 2023 18:42
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 19, 2023 •
edited
Loading

Pull Request Functional Test Report for #1910 / ab93a91

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-1.21: BGP TCP MSS and PMTUD
Cisco 8000E status
 RT-1.21: BGP TCP MSS and PMTUD
Cisco XRd status
 RT-1.21: BGP TCP MSS and PMTUD
Juniper cPTX status
 RT-1.21: BGP TCP MSS and PMTUD
Nokia SR Linux status
 RT-1.21: BGP TCP MSS and PMTUD
Openconfig Lemming status
 RT-1.21: BGP TCP MSS and PMTUD

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-1.21: BGP TCP MSS and PMTUD
Cisco 8808 status
 RT-1.21: BGP TCP MSS and PMTUD
Juniper PTX10008 status
 RT-1.21: BGP TCP MSS and PMTUD
Nokia 7250 IXR-10e status
 RT-1.21: BGP TCP MSS and PMTUD

Help

@cprabha cprabha mentioned this pull request Jul 19, 2023
Closed
@coveralls
Copy link

coveralls commented Jul 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6251711740

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.707%
Totals Coverage Status
Change from base Build 6251274160: 0.0%
Covered Lines: 1347
Relevant Lines: 2947
💛 - Coveralls

greg-dennis
greg-dennis suggested changes Jul 24, 2023
View reviewed changes
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
feature/experimental/bgp/ate_tests/bgp_tcp_mss_path_mtu/bgp_tcp_mss_path_mtu_test.go Outdated Show resolved Hide resolved
@cprabha cprabha requested a review from greg-dennis July 24, 2023 22:02
greg-dennis
greg-dennis previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Go quality

greg-dennis
greg-dennis previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for Go quality

@cprabha cprabha requested a review from a team as a code owner August 11, 2023 21:09
sachendras
sachendras previously approved these changes Sep 19, 2023
View reviewed changes
greg-dennis
greg-dennis suggested changes Sep 21, 2023
View reviewed changes
internal/deviations/deviations.go Outdated Show resolved Hide resolved
greg-dennis
greg-dennis approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Go quality

@arulkumarsekar arulkumarsekar merged commit 43c62da into openconfig:main Sep 21, 2023
10 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Sep 21, 2023
@cprabha @sachendras
@arulkumarsekar @frasieroh
RT-1.21: BGP TCP MSS and PMTUD (openconfig#1910)
eddf621 
* added automation for RT-1.21

* Added metadata

* updated ip addresses

* updated list of deviations in metadata.textproto

* Addressing review comments

* Update README.md

* added otg test

* removed deviation flag

* removed tunnel files

* added back files

* Removed ate files

* added testbed file for 2 DUT

* updated with ate2dut

* Update bgp_tcp_mss_path_mtu_test.go

* Update bgp_tcp_mss_path_mtu_test.go

* updated variable

* updated README, deleted testbed file

* updated with tested

* Addressing review comments

* Restored version in metadata.pb.go

* Updating review comments

* Fixing conflicts

* REsolved conflicts and updated README

* updated pkg name

* updated with review comments

---------

Co-authored-by: sachendras <[email protected]>
Co-authored-by: Arul Kumar Sekar <[email protected]>
@octpetre octpetre mentioned this pull request Sep 21, 2023
Closed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Sep 25, 2023
@cprabha @sachendras
@arulkumarsekar @frasieroh
RT-1.21: BGP TCP MSS and PMTUD (openconfig#1910)
d7e8d0d 
* added automation for RT-1.21

* Added metadata

* updated ip addresses

* updated list of deviations in metadata.textproto

* Addressing review comments

* Update README.md

* added otg test

* removed deviation flag

* removed tunnel files

* added back files

* Removed ate files

* added testbed file for 2 DUT

* updated with ate2dut

* Update bgp_tcp_mss_path_mtu_test.go

* Update bgp_tcp_mss_path_mtu_test.go

* updated variable

* updated README, deleted testbed file

* updated with tested

* Addressing review comments

* Restored version in metadata.pb.go

* Updating review comments

* Fixing conflicts

* REsolved conflicts and updated README

* updated pkg name

* updated with review comments

---------

Co-authored-by: sachendras <[email protected]>
Co-authored-by: Arul Kumar Sekar <[email protected]>
@sachendras sachendras mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-dennis greg-dennis greg-dennis approved these changes

@thesrinath thesrinath Awaiting requested review from thesrinath thesrinath was automatically assigned from openconfig/featureprofiles-maintainers-otg

@arulkumarsekar arulkumarsekar Awaiting requested review from arulkumarsekar

@sachendras sachendras Awaiting requested review from sachendras

Assignees
No one assigned
Labels
anCX juniper-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RT-1.21: BGP TCP MSS and PMTUD
6 participants
@cprabha @OpenConfigBot @coveralls @greg-dennis @sachendras @arulkumarsekar