-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT-1.11 - BGP remove private AS - OTG test #1853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #1853 / b40eafbVirtual Devices
Hardware Devices
|
@cprabha could you please add this test to the PR header: Resolves #1813 |
…eprofiles into bgpRmPrivateASOTG
Pull Request Test Coverage Report for Build 6162283935
💛 - Coveralls |
updated int32 to uint32
This is resolved. |
sachendras
previously approved these changes
Sep 14, 2023
jasdeep-hundal
requested changes
Sep 14, 2023
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/bgp_remove_private_as_otg_test.go
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/metadata.textproto
Outdated
Show resolved
Hide resolved
feature/experimental/bgp/otg_tests/bgp_remove_private_as/README.md
Outdated
Show resolved
Hide resolved
jasdeep-hundal
approved these changes
Sep 15, 2023
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Sep 15, 2023
* added OTG test for RT-1.11 * added metadata * updated * updated * added deviations to metadata * Update bgp_remove_private_as_otg_test.go updated int32 to uint32 * Addressing review comments * Updated README * Updated README * Update metadata.textproto * Adressing review comments --------- Co-authored-by: Arul Kumar Sekar <[email protected]>
manan-patel
pushed a commit
to manan-patel/featureprofiles
that referenced
this pull request
Sep 15, 2023
* added OTG test for RT-1.11 * added metadata * updated * updated * added deviations to metadata * Update bgp_remove_private_as_otg_test.go updated int32 to uint32 * Addressing review comments * Updated README * Updated README * Update metadata.textproto * Adressing review comments --------- Co-authored-by: Arul Kumar Sekar <[email protected]>
guoshiuan
added a commit
that referenced
this pull request
Sep 18, 2023
* added deviation to skip_interface_oper_status_lower_layer_down * deviation to update interface loopback mode using raw gnmi * fixed call * fixed GNMI raw call * updated logic for Interface_OperStatus_LOWER_LAYER_DOWN check * added Interface_OperStatus_DOWN check * rollback vendor call order * rebase * updated metadata.pb.go * Fix nil dereference (#2128) * RT-1.23 BGP AFI-SAFI OC Defaults (#2082) * Initial commit for RT-1.23 * updated metadata * Update bgp_afi_safi_defaults_test.go * Update metadata.textproto --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> * fixed the tun1.9 subnet issue (#2088) * fixed the tun1.9 subnet issue * fixing the ip address assignment guidelines --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> * RT-1.11 - BGP remove private AS - OTG test (#1853) * added OTG test for RT-1.11 * added metadata * updated * updated * added deviations to metadata * Update bgp_remove_private_as_otg_test.go updated int32 to uint32 * Addressing review comments * Updated README * Updated README * Update metadata.textproto * Adressing review comments --------- Co-authored-by: Arul Kumar Sekar <[email protected]> * updated call --------- Co-authored-by: Greg Dennis <[email protected]> Co-authored-by: cprabha <[email protected]> Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> Co-authored-by: KandukuriSudheer <[email protected]> Co-authored-by: guoshiuan <[email protected]>
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Sep 18, 2023
* added deviation to skip_interface_oper_status_lower_layer_down * deviation to update interface loopback mode using raw gnmi * fixed call * fixed GNMI raw call * updated logic for Interface_OperStatus_LOWER_LAYER_DOWN check * added Interface_OperStatus_DOWN check * rollback vendor call order * rebase * updated metadata.pb.go * Fix nil dereference (openconfig#2128) * RT-1.23 BGP AFI-SAFI OC Defaults (openconfig#2082) * Initial commit for RT-1.23 * updated metadata * Update bgp_afi_safi_defaults_test.go * Update metadata.textproto --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> * fixed the tun1.9 subnet issue (openconfig#2088) * fixed the tun1.9 subnet issue * fixing the ip address assignment guidelines --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> * RT-1.11 - BGP remove private AS - OTG test (openconfig#1853) * added OTG test for RT-1.11 * added metadata * updated * updated * added deviations to metadata * Update bgp_remove_private_as_otg_test.go updated int32 to uint32 * Addressing review comments * Updated README * Updated README * Update metadata.textproto * Adressing review comments --------- Co-authored-by: Arul Kumar Sekar <[email protected]> * updated call --------- Co-authored-by: Greg Dennis <[email protected]> Co-authored-by: cprabha <[email protected]> Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> Co-authored-by: KandukuriSudheer <[email protected]> Co-authored-by: guoshiuan <[email protected]>
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Sep 25, 2023
* added OTG test for RT-1.11 * added metadata * updated * updated * added deviations to metadata * Update bgp_remove_private_as_otg_test.go updated int32 to uint32 * Addressing review comments * Updated README * Updated README * Update metadata.textproto * Adressing review comments --------- Co-authored-by: Arul Kumar Sekar <[email protected]>
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Sep 25, 2023
* added deviation to skip_interface_oper_status_lower_layer_down * deviation to update interface loopback mode using raw gnmi * fixed call * fixed GNMI raw call * updated logic for Interface_OperStatus_LOWER_LAYER_DOWN check * added Interface_OperStatus_DOWN check * rollback vendor call order * rebase * updated metadata.pb.go * Fix nil dereference (openconfig#2128) * RT-1.23 BGP AFI-SAFI OC Defaults (openconfig#2082) * Initial commit for RT-1.23 * updated metadata * Update bgp_afi_safi_defaults_test.go * Update metadata.textproto --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> * fixed the tun1.9 subnet issue (openconfig#2088) * fixed the tun1.9 subnet issue * fixing the ip address assignment guidelines --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> * RT-1.11 - BGP remove private AS - OTG test (openconfig#1853) * added OTG test for RT-1.11 * added metadata * updated * updated * added deviations to metadata * Update bgp_remove_private_as_otg_test.go updated int32 to uint32 * Addressing review comments * Updated README * Updated README * Update metadata.textproto * Adressing review comments --------- Co-authored-by: Arul Kumar Sekar <[email protected]> * updated call --------- Co-authored-by: Greg Dennis <[email protected]> Co-authored-by: cprabha <[email protected]> Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: sachendras <[email protected]> Co-authored-by: KandukuriSudheer <[email protected]> Co-authored-by: guoshiuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added OTG test for RT-1.11 - BGP remove private AS.
Resolves : #1813
Thanks,
Prabha