Partially fix lsp_lifetime test for Arista (#2040)

feature/experimental/isis/ate_tests/isis_change_lsp_lifetime_test/isis_change_lsp_lifetime_test.go

@@ -117,6 +117,12 @@ func configureISIS(t *testing.T, dut *ondatra.DUTDevice, intfName string, dutAre
 	globalIsis.LevelCapability = oc.Isis_LevelType_LEVEL_2
 
 	globalIsis.GetOrCreateTimers().LspLifetimeInterval = ygot.Uint16(lspLifetime)
+	if deviations.ISISLspLifetimeIntervalRequiresLspRefreshInterval(dut) {
+		globalIsis.GetOrCreateTimers().LspRefreshInterval = ygot.Uint16(65535)
+	}
+	if deviations.ISISInstanceEnabledRequired(dut) {
+		globalIsis.Instance = ygot.String(isisInstance)
+	}
 
 	// Interface configs
 	intf := isis.GetOrCreateInterface(intfName)

feature/experimental/isis/ate_tests/isis_change_lsp_lifetime_test/metadata.textproto

@@ -37,6 +37,7 @@ platform_exceptions: {
     missing_value_for_defaults: true
     interface_enabled: true
     default_network_instance: "default"
-    isis_instance_enabled_required: true          
+    isis_instance_enabled_required: true
+    isis_lsp_lifetime_interval_requires_lsp_refresh_interval: true
   }
 }

internal/deviations/deviations.go

@@ -539,3 +539,9 @@ func P4RTGdpRequiresDot1QSubinterface(dut *ondatra.DUTDevice) bool {
 func ATEPortLinkStateOperationsUnsupported(ate *ondatra.ATEDevice) bool {
 	return lookupATEDeviations(ate).GetAtePortLinkStateOperationsUnsupported()
 }
+
+// ISISLspLifetimeIntervalRequiresLspRefreshInterval returns true for devices that require
+// configuring lspRefreshInterval ISIS timer when lspLifetimeInterval is configured.
+func ISISLspLifetimeIntervalRequiresLspRefreshInterval(dut *ondatra.DUTDevice) bool {
+	return lookupDUTDeviations(dut).GetIsisLspLifetimeIntervalRequiresLspRefreshInterval()
+}

proto/metadata.proto

@@ -292,6 +292,10 @@ message Metadata {
     bool ate_port_link_state_operations_unsupported = 94;
     // Creates a user and assigns role/rbac to said user via native model.
     bool set_native_user = 95;
+    // Devices require configuring lspRefreshInterval ISIS timer when
+    // lspLifetimeInterval is configured.
+    // Arista: partnerissuetracker.corp.google.com/293667850
+    bool isis_lsp_lifetime_interval_requires_lsp_refresh_interval = 96;
 
     // Reserved field numbers and identifiers.
     reserved 84, 9, 28;