P4RT: PacketOut submitted to ingress uses meaningless egress port (#2063

) * P4RT: PacketOut submitted to ingress should not require valid egress port * update readme --------- Co-authored-by: marcushines <[email protected]> Co-authored-by: Marcus Hines <[email protected]>
openconfig · Sep 1, 2023 · 4e3953d · 4e3953d
1 parent b598f69
commit 4e3953d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/feature/experimental/p4rt/ate_tests/traceroute_packetout_test/traceroute_packetout_test.go b/feature/experimental/p4rt/ate_tests/traceroute_packetout_test/traceroute_packetout_test.go
@@ -359,7 +359,7 @@ func (traceroute *TraceroutePacketIO) GetPacketOut(srcMAC, dstMAC net.HardwareAd
 			Metadata: []*p4v1.PacketMetadata{
 				{
 					MetadataId: uint32(1), // "egress_port"
-					Value:      []byte("0"),
+					Value:      []byte("submit_to_ingress"),
 				},
 				{
 					MetadataId: uint32(2), // "submit_to_ingress"

diff --git a/feature/experimental/p4rt/otg_tests/traceroute_packetout_test/README.md b/feature/experimental/p4rt/otg_tests/traceroute_packetout_test/README.md
@@ -1,10 +1,13 @@
 # P4RT-5.2: Traceroute Packetout
 
-
 ## Summary
 
 Verify that traceroute packets can be sent by the controller.
 
+### Submit to ingress specific behavior
+
+The egress port value must be set to a non empty value but will not be used. The
+setting must not interpreted as the actaul egress port id.
 
 ## Procedure
 

diff --git a/feature/experimental/p4rt/otg_tests/traceroute_packetout_test/traceroute_packetout_test.go b/feature/experimental/p4rt/otg_tests/traceroute_packetout_test/traceroute_packetout_test.go
@@ -365,7 +365,7 @@ func (traceroute *TraceroutePacketIO) GetPacketOut(srcMAC, dstMAC net.HardwareAd
 			Metadata: []*p4v1.PacketMetadata{
 				{
 					MetadataId: uint32(1), // "egress_port"
-					Value:      []byte("0"),
+					Value:      []byte("submit_to_ingress"),
 				},
 				{
 					MetadataId: uint32(2), // "submit_to_ingress"