Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/test incorrect asserts #9

Merged
merged 4 commits into from
Oct 9, 2024
Merged

fix/test incorrect asserts #9

merged 4 commits into from
Oct 9, 2024

Conversation

mimir-d
Copy link
Contributor

@mimir-d mimir-d commented Oct 8, 2024

  • fix all sorts of breakages in tests due to incorrect json assert

@mimir-d mimir-d requested a review from njordr October 8, 2024 16:52
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.4%. Comparing base (cb07377) to head (b5f9fe2).
Report is 6 commits behind head on dev.

Additional details and impacted files

@mimir-d mimir-d force-pushed the fea/typestate_measurement_series branch from e8968c3 to cb07377 Compare October 8, 2024 17:13
Base automatically changed from fea/typestate_measurement_series to dev October 9, 2024 12:57
@mimir-d
remove a bunch of boilerplate
8fa22b4 
Signed-off-by: mimir-d <[email protected]>
@mimir-d
add dependency injection for timestamps
f98061b 
- fix all sorts of breakages in tests due to incorrect json assert
- introduced some hacks, should be cleaned on this branch

Signed-off-by: mimir-d <[email protected]>
@mimir-d
typo in spec implementation
f4caa17 
- subcomponent is always full lowercase

Signed-off-by: mimir-d <[email protected]>
@mimir-d
remove annoying nulls
b5f9fe2 
- now that the tests pass, remove the nulls from the json output
- while the spec says this is ok, it just makes the tests unnecessarily
  verbose

Signed-off-by: mimir-d <[email protected]>
@mimir-d mimir-d merged commit d7e482d into dev Oct 9, 2024
12 checks passed
@mimir-d mimir-d deleted the fix/test_incorrect_asserts branch October 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njordr njordr njordr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimir-d @njordr