fix/state not necessary #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mimir-d
commented
Oct 8, 2024
mimir-d
commented
- this didnt seem to be more than the emitter, so just keep that for the time being;
- this is an impl detail, so we can revisit this later if needed
mimir-d
force-pushed
the
fix/spec
branch
2 times, most recently
from
ed3dcd0
to
fcb622e
Compare
mimir-d
force-pushed
the
fix/state_not_necessary
branch
from
384fea9
to
26baa66
Compare
njordr
approved these changes
Oct 8, 2024
- this didnt seem to be more than the emitter, so just keep that for the time being; - this is an impl detail, so we can revisit this later if needed Signed-off-by: mimir-d <[email protected]>
mimir-d
force-pushed
the
fix/state_not_necessary
branch
from
26baa66
to
f8a664e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.