fea/boxed scope #12
Merged
fea/boxed scope #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njordr
approved these changes
Oct 9, 2024
mimir-d
force-pushed
the
fix/cleanup_impl
branch
from
50347eb
to
7b78cf0
Compare
- guard this with a feature flag so users optin, since the need to use a boxed future is due to a rust syntax limitation (cannot capture lifetimes in async blocks RPIT), and this implies a stack allocation - re-add `scope` to StartedTestRun Signed-off-by: mimir-d <[email protected]>
Signed-off-by: mimir-d <[email protected]>
Signed-off-by: mimir-d <[email protected]>
- since we introduced feature flags for the first time, use cargo-hack to test all possible combinations of them Signed-off-by: mimir-d <[email protected]>
mimir-d
force-pushed
the
fea/boxed_scope
branch
from
cc17c5e
to
688f652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scopemethods but with boxed futuresboxed future is due to a rust syntax limitation (cannot capture
lifetimes in async blocks RPIT), and this implies a stack allocation