Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of section headings #14

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fix formatting of section headings #14

merged 1 commit into from
Mar 16, 2021

Conversation

gkelly
Copy link
Collaborator

@gkelly gkelly commented Dec 1, 2020

Signed-off-by: Garret Kelly [email protected]

@gkelly gkelly requested review from Bryankel and chweimer December 1, 2020 19:05
alistair23
alistair23 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@alistair23 alistair23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although it is annoying that we will loose numbered headings which are very useful in specs.

chweimer
chweimer approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@chweimer chweimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it would be nice to still have section numbers.

@chweimer chweimer merged commit 55712ca into opencomputeproject:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chweimer chweimer chweimer approved these changes

@alistair23 alistair23 alistair23 approved these changes

@Bryankel Bryankel Awaiting requested review from Bryankel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkelly @alistair23 @chweimer