Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed set_sku_mode() #198

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fixed set_sku_mode() #198

merged 1 commit into from
Sep 16, 2023

Conversation

andriy-kokhan
Copy link
Contributor

This PR fixes the failure as follows:

/usr/local/lib/python3.7/dist-packages/saichallenger/common/sai_testbed.py:218: in init
    npu.reset()
/usr/local/lib/python3.7/dist-packages/saichallenger/common/sai_npu.py:101: in reset
    self.init(attr)
/usr/local/lib/python3.7/dist-packages/saichallenger/common/sai_npu.py:83: in init
    self.set_sku_mode(self.sku_config)
/usr/local/lib/python3.7/dist-packages/saichallenger/common/sai_npu.py:215: in set_sku_mode
    serdes_oid = data.oid()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <saichallenger.common.sai_data.SaiData object at 0x7fa035ff0c50>, idx = 1

    def oid(self, idx=1):
>       value = self.to_json()[idx]
E       IndexError: list index out of range

/usr/local/lib/python3.7/dist-packages/saichallenger/common/sai_data.py:100: IndexError

@andriy-kokhan
Fixed set_sku_mode()
74f1781 
Signed-off-by: Andriy Kokhan <[email protected]>
@andriy-kokhan andriy-kokhan merged commit eda4f64 into opencomputeproject:main Sep 16, 2023
9 checks passed
selldinesh pushed a commit to selldinesh/SAI-Challenger that referenced this pull request Oct 3, 2023
@andriy-kokhan @selldinesh
Fixed set_sku_mode() (opencomputeproject#198)
c989b5a 
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>
selldinesh pushed a commit to selldinesh/SAI-Challenger that referenced this pull request Oct 5, 2023
@andriy-kokhan @selldinesh
Fixed set_sku_mode() (opencomputeproject#198)
fa41773 
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>
selldinesh added a commit to selldinesh/SAI-Challenger that referenced this pull request Oct 5, 2023
@selldinesh @yuriilisovskyi
@andriy-kokhan @vikumarks
Adding additional set of pass cases in tofino (#25)
ad9cd55 
* Add LAG hash seed test-case (opencomputeproject#184)

Signed-off-by: Yurii Lisovskyi <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* adding additional create remove cases (#14)

Signed-off-by: selldinesh <[email protected]>

* removing switch tunnel

Signed-off-by: selldinesh <[email protected]>

* resolving PR comments and merge conflict

Signed-off-by: selldinesh <[email protected]>

* resolving precommit checks

Signed-off-by: selldinesh <[email protected]>

* reverting sai and l2 basic

Signed-off-by: selldinesh <[email protected]>

* Fixed u8/u16 and range Thrift conversions (opencomputeproject#188)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Updated PTF use-case. Enabled PTF TCs run from CI/CD (opencomputeproject#189)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Fix oper status check (opencomputeproject#192)

Signed-off-by: Yurii Lisovskyi <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Added support for string SAI_NULL_OBJECT_ID for Thrift RPC (opencomputeproject#194)

Signed-off-by: Vinod Kumar <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Remove unnecessary adding BPs to default VLAN on init (opencomputeproject#193)

Signed-off-by: Yurii Lisovskyi <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Adding new DASH TCs for create, set and remove API (opencomputeproject#195)

Signed-off-by: Vinod Kumar <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Adding new DASH TCs for create, set and remove API 2nd set (opencomputeproject#197)

Signed-off-by: Vinod Kumar <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Fixed set_sku_mode() (opencomputeproject#198)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Added FDB basic UTs (opencomputeproject#199)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Added LAG basic UTs (opencomputeproject#200)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Added FDB flush UTs (opencomputeproject#201)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* [CI/CD] Fixed checks what Docker images have to be rebuild (opencomputeproject#206)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Updated to SAI v1.13+ (opencomputeproject#205)

* Added nlohmann-json3-dev as new sairedis dependency
* Extended list of unsupported types in get_by_type()
---------
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Fixed pytest warnings (opencomputeproject#207)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Refactored Redis RPC I/O failure processing (opencomputeproject#208)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Removed obsoleted exec option. Please use "--testbed" instead (opencomputeproject#209)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Add generic SAI Thrift server (opencomputeproject#203)

Signed-off-by: Yurii Lisovskyi <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* Fixed "--traffic" option behavior (opencomputeproject#210)

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>

* line ending change

Signed-off-by: selldinesh <[email protected]>

* adding additional tofino vs pass cases

* adding skip all

* pytest

---------

Signed-off-by: Yurii Lisovskyi <[email protected]>
Signed-off-by: selldinesh <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Vinod Kumar <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Co-authored-by: Yurii Lisovskyi <[email protected]>
Co-authored-by: Andriy Kokhan <[email protected]>
Co-authored-by: vikumarks <[email protected]>
Co-authored-by: Andriy Kokhan <[email protected]>
selldinesh pushed a commit to selldinesh/SAI-Challenger that referenced this pull request Oct 16, 2023
@andriy-kokhan @selldinesh
Fixed set_sku_mode() (opencomputeproject#198)
c249291 
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>
selldinesh pushed a commit to selldinesh/SAI-Challenger that referenced this pull request Oct 16, 2023
@andriy-kokhan @selldinesh
Fixed set_sku_mode() (opencomputeproject#198)
2f135f4 
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>
selldinesh pushed a commit to selldinesh/SAI-Challenger that referenced this pull request Oct 16, 2023
@andriy-kokhan @selldinesh
Fixed set_sku_mode() (opencomputeproject#198)
2bc387e 
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: selldinesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton7811 anton7811 Awaiting requested review from anton7811 anton7811 is a code owner

@yuriilisovskyi yuriilisovskyi Awaiting requested review from yuriilisovskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andriy-kokhan