Adding Test Cases for Get, Set on the Api Attributes #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selldinesh
requested review from
andriy-kokhan and
anton7811
as code owners
tests/api/test_acl_counter.py
Outdated
| @@ -1,41 +1,41 @@ | |||
|
|
|||
There was a problem hiding this comment.
please remove empty line
tests/api/test_acl_counter.py
Outdated
| }, | ||
| ] | ||
|
|
||
| commands = [{'name': 'acl_table_1', 'op': 'create', 'type': 'SAI_OBJECT_TYPE_ACL_TABLE', 'attributes': ['SAI_ACL_TABLE_ATTR_ACL_STAGE', 'SAI_ACL_STAGE_INGRESS']}, {'name': 'acl_counter_1', 'op': 'create', 'type': 'SAI_OBJECT_TYPE_ACL_COUNTER', 'attributes': ['SAI_ACL_COUNTER_ATTR_TABLE_ID', '$acl_table_1']}] |
There was a problem hiding this comment.
As for me, the previous version was much more readable. Could you please revert?
tests/api/test_acl_counter.py
Outdated
|
|
||
| def test_acl_counter_remove(self, npu): | ||
|
|
||
| commands = [{'name': 'acl_counter_1', 'op': 'remove'}, {'name': 'acl_table_1', 'op': 'remove'}] |
selldinesh
force-pushed
the
pr_phase2_get_set
branch
from
0a9be86 to
57f7ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Contributing SAI test cases that qualifies the SAI apis. This PR consists of test cases that does Get and Set operation on the API.
The cases have been validated to be passing on Edgecore DUT with Broadcom asic
SAI-Challenger Version: : 40e09a6