Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accton][as7535-28xb] modified the display of onlpdump -x #991

Closed

Conversation

acctalex
Copy link
Contributor

  1. modified the code layout to fit the Linux coding style and added a sysfs, cpu_cpld_version, in x86-64-accton-as7535-28xb-sys.c

  2. modified to show CPLD, FPGA, BIOS, ONIE, and BMC versions when using onlpdump -x

1. modified the code layout to fit the Linux coding style and
   added a sysfs, cpu_cpld_version, in x86-64-accton-as7535-28xb-sys.c

2. modified to show CPLD, FPGA, BIOS, ONIE, and BMC versions when
   using onlpdump -x

Signed-off-by: Alex Lai <[email protected]>
@paulmenzel
Copy link

Please use present tense in the commit message, and please split up the commit into smaller chunks. I’d put the code format changes in a separate commit. Please add the diff between the old and new output of onlpdump -x to the corresponding commit message.

@acctalex acctalex closed this Aug 23, 2024
@acctalex acctalex deleted the onlpdump_x_fw_ver branch August 23, 2024 08:24
@paulmenzel
Copy link

Superseded by merge/pull request #992.

In the future, you can just force push to the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants