Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in Nunavut districts #374

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add in Nunavut districts #374

merged 2 commits into from
Apr 29, 2024

Conversation

seamuslee001
Copy link
Contributor

This is based on the list of Constituencies here https://www.elections.nu.ca/en/constituency-map

@seamuslee001 seamuslee001 mentioned this pull request Apr 26, 2024
Merged
evannjw
evannjw reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@evannjw evannjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these districts don't seem to have ids, consider using names as district identifiers. ex. ocd-division/country:ca/territory:nu/ed:1 -> ocd-division/country:ca/territory:nu/ed:aggu

@jpmckinney
Copy link
Member

Agreed

@jpmckinney jpmckinney merged commit f17890d into opencivicdata:master Apr 29, 2024
1 check passed
@jpmckinney jpmckinney added the CA label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evannjw evannjw evannjw approved these changes

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
CA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @jpmckinney @evannjw