Update lok_sabha.csv #372
Merged
Update lok_sabha.csv #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
change in india ocdids in the loksabha.csv |
rpanczer
approved these changes
Apr 3, 2024
azuser
requested changes
Apr 3, 2024
azuser
requested changes
Apr 3, 2024
azuser
requested changes
Apr 5, 2024
identifiers/country-in/lok_sabha.csv
Outdated
| @@ -549,9 +549,11 @@ ocd-division/country:in/territory:dl/cd:south_delhi,Delhi Lok Sabha constituency | |||
| ocd-division/country:in/territory:dl/cd:west_delhi,Delhi Lok Sabha constituency West Delhi,, | |||
| ocd-division/country:in/territory:dn/cd:dadra_and_nagar_haveli,Dadra and Nagar Haveli Lok Sabha constituency Dadra and Nagar Haveli (ST),,2020-01-25 | |||
| ocd-division/country:in/territory:jk/cd:anantnag,Jammu and Kashmir Lok Sabha constituency Anantnag,2019-10-31, | |||
| ocd-division/country:in/territory:jk/cd:anantnag-rajouri,Jammu and Kashmir Lok Sabha constituency anantnag-rajouri,, | |||
There was a problem hiding this comment.
Can you add the date from when the renaming was applied ?
There was a problem hiding this comment.
Sure, please see the updates.
azuser
reviewed
Apr 8, 2024
identifiers/country-in/lok_sabha.csv
Outdated
| @@ -549,9 +549,11 @@ ocd-division/country:in/territory:dl/cd:south_delhi,Delhi Lok Sabha constituency | |||
| ocd-division/country:in/territory:dl/cd:west_delhi,Delhi Lok Sabha constituency West Delhi,, | |||
| ocd-division/country:in/territory:dn/cd:dadra_and_nagar_haveli,Dadra and Nagar Haveli Lok Sabha constituency Dadra and Nagar Haveli (ST),,2020-01-25 | |||
| ocd-division/country:in/territory:jk/cd:anantnag,Jammu and Kashmir Lok Sabha constituency Anantnag,2019-10-31, | |||
| ocd-division/country:in/territory:jk/cd:anantnag-rajouri,Jammu and Kashmir Lok Sabha constituency anantnag-rajouri,2022-05-05, | |||
| ocd-division/country:in/territory:jk/cd:baramulla,Jammu and Kashmir Lok Sabha constituency Baramulla,2019-10-31, | |||
| ocd-division/country:in/territory:jk/cd:jammu,Jammu and Kashmir Lok Sabha constituency Jammu,2019-10-31, | |||
| ocd-division/country:in/territory:jk/cd:ladakh,Jammu and Kashmir Lok Sabha constituency Ladakh,2019-10-31, | |||
There was a problem hiding this comment.
Please remove the ladakh constituency attached to territory:jk.
azuser
reviewed
Apr 11, 2024
identifiers/country-in/lok_sabha.csv
Outdated
| ocd-division/country:in/territory:jk/cd:srinagar,Jammu and Kashmir Lok Sabha constituency Srinagar,2019-10-31, | ||
| ocd-division/country:in/territory:jk/cd:udhampur,Jammu and Kashmir Lok Sabha constituency Udhampur,2019-10-31, | ||
| ocd-division/country:in/territory:ld/cd:lakshadweep,Lakshadweep Lok Sabha constituency Lakshadweep (ST),, | ||
| ocd-division/country:in/territory:py/cd:puducherry,Puducherry Lok Sabha constituency Puducherry,, | ||
| ocd-division/country:in/territory:la/cd:ladakh,ladakh Lok Sabha constituency ladakh,2019-10-31, |
There was a problem hiding this comment.
Can you add this new entry respecting the existing alphabetical order.
jloutsenhizer
requested changes
Apr 15, 2024
|
The changes look good, but compile.py still needs to be run |
|
I see |
raghu1061998
force-pushed
the
raghu1061998-patch-1
branch
from
e9e4abd to
ea1f81e
Compare
jloutsenhizer
approved these changes
Apr 25, 2024
jpmckinney
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
In summary:
- territory:jk/cd:ladakh was incorrectly entered as being valid from 2019-10-31, when in fact it was valid until 2019-10-30 and then replaced by territory:la/cd:ladakh, which was valid from 2019-10-31.
- anantnag became anantnag-rajouri on 2022-05-05.
Please use the "Squash and merge" button option when merging, because 19 commits for 2 changes makes for a very strange version history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
Please see the updates in the lok_sabha.csv line no 157 and 161 regarding the name and territory updates.