Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot(npm): bump ng-terminal from 5.7.0 to 6.0.0 #527

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps ng-terminal from 5.7.0 to 6.0.0.

Release notes

Sourced from ng-terminal's releases.

Change Log for v6.0.0

Minor updates

  • Refactor ng-terminal component codes.
  • Add some new cases to test whether it works well with the tab of ngxbootstrap.
  • Use setTimeout() without using callbacks of observables (It can be changed in the future).

Change Log for v6.0.0-beta

ng-terminal doesn't support versions below v14 to support only Angualr LTS versions.

  • Update Angular to v14 (strict check has been applied)
  • Make some comments on important functions
  • Mark @​deprecated on some old codes which would be removed soon
  • Refactor/Rename fields and methods
  • Extract and move some queue codes into LinearRenderService
Commits
  • 76c658a bump the version to v6.0.0
  • 50e4978 refactor the whole codes and split the large function into small ones. (#78)
  • 2556e62 recover README.md and CI file
  • 4fc5c4f Update Angular to v14 and make some improvments
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ng-terminal](https://github.com/qwefgh90/ng-terminal) from 5.7.0 to 6.0.0.
- [Release notes](https://github.com/qwefgh90/ng-terminal/releases)
- [Commits](qwefgh90/ng-terminal@v5.7.0...v6.0.0)

---
updated-dependencies:
- dependency-name: ng-terminal
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Collaborator

@djerfy djerfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@djerfy djerfy merged commit 0520d24 into main Dec 11, 2023
4 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ng-terminal-6.0.0 branch December 11, 2023 18:37
@william-gr
Copy link
Contributor

Need to check if this wont break the web console/logs, since its a major version change

@djerfy
Copy link
Collaborator

djerfy commented Dec 12, 2023

Need to check if this wont break the web console/logs, since its a major version change

Of course! For minor change I read the changelog, but for major change, I test on localhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants