Properly center and space end screen #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the issue that the text and the check mark icon of the end screen is pushed to the top of the end space with basically no spacing. This is caused by an incorrect CSS calculation.
|
This pull request is deployed at test.editor.opencast.org/1467/2024-10-08_21-34-41/ . |
|
Do you want this to supercede #1414 ? |
|
Ups, did miss that. Sorry. |
|
I also don't have a major preference. Yours is probably better? (Intent of the CSS is more clear, don't need to add an unnecessary div to the DOM) |
Arnei
approved these changes
Oct 10, 2024
|
Okay, merging this, closing #1414 to finish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue that the text and the check mark icon of the end screen is pushed to the top of the end space with basically no spacing. This is caused by an incorrect CSS calculation.
Before:
After:
