Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace iarna/toml with smol-toml #1423

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Replace iarna/toml with smol-toml #1423

merged 4 commits into from
Oct 15, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 10, 2024

Our build logs were complaining:

node_modules/@iarna/toml/lib/toml-parser.js (153:22): Use of eval in "node_modules/@iarna/toml/lib/toml-parser.js" is strongly discouraged as it poses security risks and may cause issues with minification.

Unfortunately, iarna/toml appears to be unmaintained, so this likely won't get fixed. This patch replaces it with another toml parser that causes no build complaints and is actively maintained.

@Arnei
Replace iarna/toml with smol-toml
b9ef5fb 
Our build logs were complaining:

> node_modules/@iarna/toml/lib/toml-parser.js (153:22): Use of eval in "node_modules/@iarna/toml/lib/toml-parser.js" is strongly discouraged as it poses security risks and may cause issues with minification.

Unfortunately, iarna/toml appears to be unmaintained,
so this likely won't get fixed. This patch replaces
it with another toml parser that causes no
build complaints and is actively maintained.
@Arnei Arnei added the type:dependencies Pull requests that update a dependency file label Jul 10, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1423/2024-07-10_13-46-37/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

This pull request is deployed at test.editor.opencast.org/1423/2024-09-02_14-55-26/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Oct 10, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1423/2024-10-15_12-48-30/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Oct 15, 2024
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1423/2024-10-15_12-53-44/ .
It might take a few minutes for it to become available.

@Arnei Arnei merged commit b4427dc into opencast:main Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arnei