Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of ProtoButton from appkit #1393

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Make use of ProtoButton from appkit #1393

merged 4 commits into from
Dec 17, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 27, 2024 •
edited
Loading

Replaces our home-brewed buttons with the basic ProtoButtons from appkit. There is arguably more work to be done on buttons, but this should serve as a good foundation for such future work.

Helps with #1381.

No screenshots this time, as everything should look and work the same. The benefits here are in code quality and potentially improvements in accessibility.

@Arnei
Make use of ProtoButton from appkit
5e15645 
Replaces our home-brewed buttons with the
basic ProtoButtons from appkit. There is arguably
more  work to be done on buttons, but this should
serve as a good foundation for such future work.
@Arnei Arnei added the type:code-quality Internal improvements to the codebase label Jun 27, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1393/2024-06-27_14-57-15/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

This pull request is deployed at test.editor.opencast.org/1393/2024-07-03_08-35-26/ .
It might take a few minutes for it to become available.

@geichelberger geichelberger self-assigned this Dec 5, 2024
@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

This pull request is deployed at test.editor.opencast.org/1393/2024-12-06_08-33-05/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 10, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1393/2024-12-10_08-37-37/ .
It might take a few minutes for it to become available.

geichelberger
geichelberger approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@geichelberger geichelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geichelberger geichelberger merged commit 00bc540 into opencast:main Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geichelberger geichelberger geichelberger approved these changes

Assignees

@geichelberger geichelberger

Labels
type:code-quality Internal improvements to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arnei @geichelberger