Fix initial appearance of thumbnail view #1365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the boxes for the thumbnails and the videos to be roughly the same size, and display the buttons in the thumbnail boxes on the right if space allows. This was not happening when first clicking on the thumbnail view, wasting space and giving it a generally not so great look. This changes some max widths around to fix that.
|
This pull request is deployed at test.editor.opencast.org/1365/2024-05-30_07-46-30/ . |
|
Looks good to me in various browsers (Firefox, Chrome, Safari) with one small flaw. If you have a dual stream recording and a small browser window, the thumbnail placeholder does not scale. If you have a single stream recording, the scaling of the thumbnail placeholder works fine: One other remark: in Safari the preview videos are smaller than in other browsers, but this is already fixed by this PR #1383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the boxes for the thumbnails and the videos to be roughly the same size, and display the buttons in the thumbnail boxes on the right if space allows. This was not happening when first clicking on the thumbnail view, wasting space and giving it a generally not so great look. This changes some max widths around to fix that.
Potentially a fix for #1282.
Before
After
