Enforce eslint no-explicit-any #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds more typing, but also adds a few eslint exceptions. I tried to keep the exceptions to types were it makes sense to keep `any` (i.e. third party libraries returning it or just cases were we don't care about the contents of a variable). This may be controversial though.
|
This pull request is deployed at test.editor.opencast.org/1260/2024-01-19_12-34-21/ . |
geichelberger
requested changes
Mar 20, 2024
Since there are no more default overwriting rules, we can remove the rule object entirely.
The comment is not needed anymore so it can go.
|
This pull request is deployed at test.editor.opencast.org/1260/2024-03-25_08-37-30/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more typing, but also adds a few eslint exceptions. I tried to keep the exceptions to types were it makes sense to keep
any(i.e. third party libraries returning it or just cases were we don't care about the contents of a variable). This may be controversial though.