Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1186, incorrect color of btn icons on hover #1187

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix #1186, incorrect color of btn icons on hover #1187

merged 1 commit into from
Oct 31, 2023

Conversation

maheshchandra10
Copy link
Contributor

Fixes #1186

color property of the icon-class is overriding the color property of button-class on hover.

@github-actions
Copy link

Hi @maheshchandra10
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@maheshchandra10 maheshchandra10 changed the title fix(button): incorrect color of btn icons on hover fix #1186, incorrect color of btn icons on hover Oct 26, 2023
@maheshchandra10 maheshchandra10 changed the title fix #1186, incorrect color of btn icons on hover Fix #1186, incorrect color of btn icons on hover Oct 26, 2023
@owi92 owi92 added the type:accessibility This would help impaired users label Oct 26, 2023
owi92
owi92 approved these changes Oct 26, 2023
View reviewed changes
Copy link

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the fix! Once you have filed the required ICLA thingy (see the gh actions comment above), I'd say this can get merged.

@maheshchandra10
Copy link
Contributor Author

Cool, thanks for the fix! Once you have filed the required ICLA thingy (see the gh actions comment above), I'd say this can get merged.

I filled it as soon as I got this error, but I guess it still hasn't updated where it's supposed to be updated :(

@github-actions
Copy link

Hi @maheshchandra10
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@KatrinIhler
Copy link
Member

Maybe it still needs some time before that ICLA is processed (a list of the currently completed ICLA's can be found here: https://licensing.apereo.org/).

@gregorydlogan
Copy link
Member

ICLA is now on file, so this is good to go

@Arnei Arnei merged commit 9e99dc3 into opencast:main Oct 31, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owi92 owi92 owi92 approved these changes

Assignees
No one assigned
Labels
type:accessibility This would help impaired users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High contrast: Icon color of buttons in track selection view should invert on hover
5 participants
@maheshchandra10 @KatrinIhler @gregorydlogan @owi92 @Arnei