Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align track view button placement with thumbnail view #1158

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Sep 14, 2023

Makes the button in the track selection view behave more similar to how the thumbnail generation buttons behave.

Since there's only one button ("Delete Track"),
I'm a little worried if it still parses as a button without a border.

Aims to resolve #1157.

Makes the button in the track selection view behave more
similar to how the thumbnail generation buttons behave.

Since there's only one button ("Delete Track"),
I'm a little worried if it still parses as a button without a border.
@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label Sep 14, 2023
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1158/2023-09-14_08-10-25/ .
It might take a few minutes for it to become available.

Copy link

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
One thing I noticed when looking at these buttons is that their icon color isn't inverted on hover in high contrast modes. But that's neither introduced by nor subject of this PR - I'll open a separate issue.

Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Oct 31, 2023
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

This pull request is deployed at test.editor.opencast.org/1158/2023-11-01_09-13-03/ .
It might take a few minutes for it to become available.

@Arnei Arnei merged commit 57445db into opencast:main Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button Placement in Track and Thumbnail
2 participants