Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement editor locking so only one person can edit a recording a time #1102

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

JamesUoM
Copy link
Contributor

This works with the corresponding feature in Opencast [1] when it is enabled in the editor service config. When locking is enabled only one person can edit a video at time. This is for the use case where multiple people have access to a video and may have been notified it is ready for editing.

[1] opencast/opencast#4658

UoM: MAT-468

@JamesUoM JamesUoM added the type:feature A new feature or feature request label Jul 12, 2023
@@ -28,7 +29,10 @@ const Body: React.FC = () => {
)
} else if (isEnd) {
return (
<TheEnd />
<div>
<Lock />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock component appears here so that any lock can be freed on discarding of edits

@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1102/2023-07-12_12-28-27/ .
It might take a few minutes for it to become available.

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works in testing. Gets an "Approved" from me!

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Aug 31, 2023
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@KatrinIhler
Copy link
Member

@JamesUoM Could you resolve the conflicts so we can merge this?

# Conflicts:
#	src/redux/videoSlice.ts
#	src/util/utilityFunctions.ts
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This pull request is deployed at test.editor.opencast.org/1102/2023-10-04_14-00-32/ .
It might take a few minutes for it to become available.

@Arnei Arnei merged commit c2147ae into opencast:main Oct 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature A new feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants