-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement editor locking so only one person can edit a recording a time #1102
Conversation
@@ -28,7 +29,10 @@ const Body: React.FC = () => { | |||
) | |||
} else if (isEnd) { | |||
return ( | |||
<TheEnd /> | |||
<div> | |||
<Lock /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock component appears here so that any lock can be freed on discarding of edits
This pull request is deployed at test.editor.opencast.org/1102/2023-07-12_12-28-27/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works in testing. Gets an "Approved" from me!
This pull request has conflicts ☹ |
@JamesUoM Could you resolve the conflicts so we can merge this? |
# Conflicts: # src/redux/videoSlice.ts # src/util/utilityFunctions.ts
2ffcc37
to
9a1d8ce
Compare
This pull request is deployed at test.editor.opencast.org/1102/2023-10-04_14-00-32/ . |
This works with the corresponding feature in Opencast [1] when it is enabled in the editor service config. When locking is enabled only one person can edit a video at time. This is for the use case where multiple people have access to a video and may have been notified it is ready for editing.
[1] opencast/opencast#4658
UoM: MAT-468