fixes #30 #31
Open
fixes #30 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfsx
requested changes
Sep 13, 2024
| @@ -525,20 +525,24 @@ protected function setStyleFromProps(ilTemplate $tpl, array $properties) | |||
| $tpl->setVariable('RATIO', $ratio); | |||
| $tpl->setVariable('MAX-WIDTH', $properties[self::PROP_WIDTH]); | |||
| $tpl->setVariable('MAX-HEIGHT', $properties[self::PROP_HEIGHT]); | |||
| if ($properties[self::PROP_RESPONSIVE] != false) { | |||
| $tpl->setVariable('WIDTH', 'width:100%;'); | |||
| if (array_key_exists(self::PROP_RESPONSIVE, $properties)) { | |||
There was a problem hiding this comment.
I suggest to use a Null Coalescing Operator:
if ((bool)($properties[self::PROP_RESPONSIVE] ?? false) === true) {
$tpl->setVariable('WIDTH', 'width:100%;');
}
as well as a more strict type handling, and last but not least turning the logic from != false to === true which is more readable.
| $tpl->setVariable('CONTAINER_STYLE', 'text-align:left;'); | ||
| break; | ||
| if (array_key_exists(self::PROP_POSITION, $properties)) { | ||
| switch ($properties[self::PROP_POSITION]) { |
There was a problem hiding this comment.
Same here, instead of using array_key_exists you can just use
switch ($properties[self::PROP_POSITION] ?? null) {
|
Can we fix the error and transfer it to the production version? |
|
Thank you, I changed the PR and added your suggestions |
chfsx
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a check with array_key_exists() to fix #30