Do not allow penalty payer to be null in settle funds in ts client #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrrb
reviewed
Feb 6, 2024
skrrb
approved these changes
Feb 6, 2024
|
@brittcyr i've pushed a new version of the client with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program requires it as a signer.
https://github.com/openbook-dex/openbook-v2/blob/master/programs/openbook-v2/src/accounts_ix/settle_funds.rs#L11
The default key that the client otherwise uses does not work because the web3.js client fails signature validation in preflight.