Suggested councillor council name #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for Council Name is nested in the feature_flag_is_on test, so that the feature is visible in the test environment.
henare
reviewed
Jun 22, 2017
There was a problem hiding this comment.
Great, simple implementation that does the basics first. I think it could be worth improving the text to be more helpful and descriptive.
@hisayohorie would you like to do that or would you prefer we just merge this so you can move on to something else first?
| @@ -1,3 +1,6 @@ | |||
| %p | |||
There was a problem hiding this comment.
Should this be a header instead of a paragraph?
| @@ -1,3 +1,6 @@ | |||
| %p | |||
| Council Name: #{@authority.full_name} | |||
There was a problem hiding this comment.
Since this line is so short it could go on the same line as the tag, i.e.:
%p Council Name: #{@authority.full_name}to make it more readable and clear. still need some styling.
To separate the test exercise and test expectation.
henare
approved these changes
Jun 22, 2017
There was a problem hiding this comment.
@hisayohorie and I left the h1 text with the default styling because that will be done in #1180. We also decided to leave adding an introductory paragraph until we add other helpful text in #1182.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will display the name of council the suggested councillors belong.
Fixes #1181 .