Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic styles to the councillor contribution form #1180

Closed
equivalentideas opened this issue Jun 20, 2017 · 6 comments
Closed

Add basic styles to the councillor contribution form #1180

equivalentideas opened this issue Jun 20, 2017 · 6 comments
Assignees
Labels
UX Related to interface improvements

Comments

@equivalentideas
Copy link
Contributor

equivalentideas commented Jun 20, 2017

It currently appears as:

screen shot 2017-07-27 at 8 14 14 pm

Extracted from #1160

@equivalentideas
Copy link
Contributor Author

equivalentideas commented Jul 28, 2017

So I think the basic things to get this into shape for the first pass are:

  • get the heading down to a size that doesn't dominate the form, it should draw attention so people know what the page is about and lead people into the next action.
  • Style the form input elements to match the general app style that works well, bolder labels and clearer inputs.
  • Differentiate the submit form and add a councillor buttons, in both colour and proximity. I think the 'add a councillor' button should align to the left hand side of the inputs so it's a clear line down the form (sitting it the place that the new councillor form will appear). The submit button should be on the right (conventionally signifying progressing through something), and be a bit lower than the form itself. The submit button should be the colour of the submit buttons across the site, the add a councillor button should be grey maybe? or blue?
  • align the form inputs, and the submitted council records horizontally, so that the names and emails of all the councillors submitted line up. This helps you see if there's a typo in the email formatting, and quickly scan up and down the names.

@equivalentideas
Copy link
Contributor Author

I'm mid way through this, working on branch councillor_contribution_basic_styles:

screen shot 2017-07-28 at 6 37 16 pm

Haven't done anything with the submitted councillors yet:

screen shot 2017-07-28 at 6 39 47 pm

@hisayohorie it would be great to get your thoughts and feedback on this. Going in the right direction?

@hisayohorie
Copy link
Contributor

@equivalentideas yes, I think it looks great!

@equivalentideas
Copy link
Contributor Author

@equivalentideas yes, I think it looks great!

Thanks @hisayohorie I'll continue along that path then 🚠

@equivalentideas
Copy link
Contributor Author

I've done the bits on the list above and a couple of small other bits, I'll open a PR 🖼

@equivalentideas
Copy link
Contributor Author

Closed by #1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Related to interface improvements
Projects
None yet
Development

No branches or pull requests

2 participants