Move size out of share icon

openaustralia · Sep 13, 2024 · eb16beb · eb16beb
1 parent 9ddb0af
commit eb16beb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/components/icon_component.html.erb b/app/components/icon_component.html.erb
@@ -14,8 +14,7 @@
     <path d="M16.3284 18.164H1.83569V3.6717H8.79011V1.83594H0V20H18.1641V11.2099H16.3284L16.3284 18.164Z" />
   </svg>
 <% when :share %>
-  <%# TODO: Move size out of here %>
-  <svg class="size-5" viewBox="0 0 22 27" fill="none" stroke="currentColor" xmlns="http://www.w3.org/2000/svg">
+  <svg viewBox="0 0 22 27" fill="none" stroke="currentColor" xmlns="http://www.w3.org/2000/svg">
     <path d="M2 13.5V22.7C2 23.31 2.23705 23.895 2.65901 24.3263C3.08097 24.7577 3.65326 25 4.25 25H17.75C18.3467 25 18.919 24.7577 19.341 24.3263C19.7629 23.895 20 23.31 20 22.7V13.5M15.5 6.6L11 2M11 2L6.5 6.6M11 2V16.95" stroke-width="3" stroke-linecap="round" stroke-linejoin="round" />
   </svg>
 <% when :tick %>

diff --git a/app/components/share_button_component.html.erb b/app/components/share_button_component.html.erb
@@ -28,7 +28,7 @@
     <%# Giving this a constant height to avoid any content shifts when button is clicked %>
     <div class="flex items-baseline justify-center h-8 gap-4">
       <div>
-        <div x-show="!copied"><%= render IconComponent.new(name: :share) %></div>
+        <div x-show="!copied" class="size-5"><%= render IconComponent.new(name: :share) %></div>
         <div x-show="copied" class="size-5"><%= render IconComponent.new(name: :tick) %></div>
       </div>
       <div>