Skip to content

Commit

Permalink
Switch to using several h1's on the landing page
Browse files Browse the repository at this point in the history
This makes the styling of the headers more consistent with the overall standard styling
  • Loading branch information
mlandauer committed Feb 26, 2024
1 parent 805b042 commit 758b782
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 12 deletions.
3 changes: 1 addition & 2 deletions app/views/_tailwind/home/_how_is_this_free.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<%# TODO: The words here are a start and are good in spirit but not totally accurate so need updating %>
<section class="pt-12 pb-16">
<%# TODO: Non-standard style %>
<%= render Tailwind::Heading.new(tag: :h2, size: "4xl", extra_classes: "pb-8").with_content("How is this free?") %>
<%= render Tailwind::Heading.new(tag: :h1, extra_classes: "pb-8").with_content("How is this free?") %>
<div class="flex flex-col gap-8 lg:flex-row">
<div>
<p class="text-2xl text-navy">
Expand Down
9 changes: 4 additions & 5 deletions app/views/_tailwind/home/_how_it_works.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<section class="pb-8 text-navy">
<%# TODO: Using non-standard style %>
<%= render Tailwind::Heading.new(tag: :h2, size: "4xl", extra_classes: "mt-20").with_content("How it works") %>
<%= render Tailwind::Heading.new(tag: :h1, extra_classes: "mt-20").with_content("How it works") %>
<p class="mt-6 text-2xl">
Planning Alerts collects information from as many local councils and state planning authorities across Australia as possible, so that you can&hellip;
</p>
Expand All @@ -10,7 +9,7 @@
<div class="before:[content:counter(section)] flex items-center relative -left-10 justify-center bg-lavender w-20 h-20 rounded-full before:text-white before:font-semibold before:text-3xl">
</div>
</div>
<%= render Tailwind::Heading.new(tag: :h3, font: "sans", weight: "semibold", extra_classes: "pb-4").with_content("Search") %>
<%= render Tailwind::Heading.new(tag: :h2, size: "2xl", font: "sans", weight: "semibold", extra_classes: "pb-4").with_content("Search") %>
<%= image_tag "tailwind/illustration/search.svg", size: "200x144", class: "mx-auto mb-5", alt: "" %>
Search for applications in an area you're interested in
</li>
Expand All @@ -19,7 +18,7 @@
<div class="before:[content:counter(section)] flex items-center relative -left-10 justify-center bg-lavender w-20 h-20 rounded-full before:text-white before:font-semibold before:text-3xl">
</div>
</div>
<%= render Tailwind::Heading.new(tag: :h3, font: "sans", weight: "semibold", extra_classes: "pb-4").with_content("Get notified!") %>
<%= render Tailwind::Heading.new(tag: :h2, size: "2xl", font: "sans", weight: "semibold", extra_classes: "pb-4").with_content("Get notified!") %>
<%= image_tag "tailwind/illustration/get-notified.svg", size: "200x131", class: "mx-auto mb-8", alt: "" %>
Sign up to receive email notifications about future developments in your search area.
</li>
Expand All @@ -28,7 +27,7 @@
<div class="before:[content:counter(section)] flex items-center relative -left-10 justify-center bg-lavender w-20 h-20 rounded-full before:text-white before:font-semibold before:text-3xl">
</div>
</div>
<%= render Tailwind::Heading.new(tag: :h3, font: "sans", weight: "semibold", extra_classes: "pb-4").with_content("Comment") %>
<%= render Tailwind::Heading.new(tag: :h2, size: "2xl", font: "sans", weight: "semibold", extra_classes: "pb-4").with_content("Comment") %>
<%= image_tag "tailwind/illustration/comment.svg", size: "200x165", class: "mx-auto", alt: "" %>
Look through the applications that interest you and comment on them. Comments get sent directly
to council and are posted publicly on Planning Alerts.
Expand Down
3 changes: 1 addition & 2 deletions app/views/_tailwind/home/_stats.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<% cache "stats", expires_in: 1.hour do %>
<section class="pt-12 text-xl text-navy">
<%# TODO: Non-standard style %>
<%= render Tailwind::Heading.new(tag: :h2, size: "4xl", extra_classes: "mb-12").with_content("This week at Planning Alerts") %>
<%= render Tailwind::Heading.new(tag: :h1, extra_classes: "mb-12").with_content("This week at Planning Alerts") %>
<ul class="grid gap-12 text-center sm:grid-cols-2 lg:grid-cols-4">
<li>
<%= link_to applications_path, class: "text-fuchsia focus:bg-sun-yellow block" do %>
Expand Down
4 changes: 1 addition & 3 deletions app/views/_tailwind/home/_trending.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<section class="pb-12">
<%# TODO: Non-standard style %>
<%# TODO: Should this actually be an h1? %>
<%= render Tailwind::Heading.new(tag: :h2, size: "4xl", extra_classes: "mt-20").with_content("Most commented applications") %>
<%= render Tailwind::Heading.new(tag: :h1, extra_classes: "mt-20").with_content("Most commented applications") %>
<p class="mt-4 text-2xl text-navy">
Some planning applications attract considerably more community interest than others.
We bring you the trending applications so you can see what people find most popular or contentious.
Expand Down

0 comments on commit 758b782

Please sign in to comment.