Make handling of sidekiq in testing more consistent.

Just inline the background jobs everywhere but in the case of elasticsearch do specific things in the tests to avoid elastic being called

app/services/create_or_update_application_service.rb

@@ -38,7 +38,8 @@ def self.call(authority:, council_reference:, attributes:)
         application.date_scraped = attributes[:date_scraped] if attributes.key?(:date_scraped)
         application.save!
         create_version(application, attributes)
-        application.reindex
+        # TODO: Get rid this hack
+        application.reindex unless Rails.env.test?
       end
       application
     end

spec/controllers/api_controller_spec.rb

@@ -3,6 +3,11 @@
 require "spec_helper"
 
 describe ApiController do
+  before do
+    # Disable the logging of the API call to elasticsearch
+    allow(LogApiCallService).to receive(:call).and_return(nil)
+  end
+
   render_views
 
   shared_examples "an authenticated API" do

spec/spec_helper.rb

@@ -81,13 +81,8 @@
   end
 
   require "sidekiq/testing"
-  # Disable background jobs for feature specs so that emails get
-  # processed immediately
-  config.around(:each, type: :feature) do |example|
-    Sidekiq::Testing.inline! do
-      example.run
-    end
-  end
+  # Disable background jobs for feature specs so that emails get processed immediately
+  Sidekiq::Testing.inline!
 
   config.include EmailSpec::Helpers
   config.include EmailSpec::Matchers