Fix page objects offset with Chrome 73 #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to fix the issue openanalytics#139 regarding the offset. We noticed this when Shinydashboard is used with Chrome 73.
LEDfan
force-pushed
the
develop
branch
3 times, most recently
from
acdf6cd
to
3443eb8
Compare
|
Hi, thank you for your contribution. Did you test whether this is still an issue in more recent releases of ShinyProxy? The method of setting up the iframe height has changed a few released ago and I think it should fix this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the issue #139 regarding the offset. We noticed this when Shinydashboard with collapsible entries is used with Chrome 73. This triggers a displacement of the objects.
Changing the css from
padding-toptomargin-topseems to fix this.