Introduce OpenAIThrowable #429
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
interface
branch
from
7ad8627
to
d0a3770
Compare
|
Friendly ping @nunomaduro @gehrisandro, Is something missing for a review ? Thanks |
|
I agree that this is a useful and beneficial improvement. I see no reason why this cannot be merged @nunomaduro |
|
Anyway to move forward this PR @gehrisandro @nunomaduro ? Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Hi @gehrisandro
I'm trying to move #287 forward by splitting it in 3 smaller PRs:
The purpose of this PR is to provide an easy way to try/catch method of this lib:
\Exceptionwhich catch everythingOpenAI\Exceptions\ErrorException|OpenAI\Exceptions\InvalidArgumentException|...which is complicated and can miss an exception if a new one is introduced later.Related:
#287