SW3: Timebox rule creation #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it should not be negative
so that's C1, C2 and B
…and new name of option have enum to help refer to validation modes and using validationMode rather than just mode for the option key
…ircumstances If oa:prepayment is https://openactive.io/Required or https://openactive.io/Optional, then oa:availableChannel must contain at least one of https://openactive.io/OpenBookingPrepayment, https://openactive.io/TelephonePrepayment or https://openactive.io/OnlinePrepayment
of Offer rather than just targeting the Offer model
…l being an array original implementation assumed it was a single value but in the model specification it's an array
if there is an imperative config for the validation mode being used
ylt
approved these changes
Oct 29, 2019
thtg88
reviewed
Oct 29, 2019
src/rules/data-quality/event-remaining-attendee-capacity-rule-spec.js
Outdated
Show resolved
Hide resolved
thtg88
approved these changes
Oct 29, 2019
henryaddison
force-pushed
the
sw3/timebox-rule-creation
branch
from
1a23182 to
3e36d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules added are:
NB the shallNotInclude won't effect anything yet as no model specification yet includes validationModes or imperativeConfiguration attributes.