Update useradd script to prevent warnings #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity Not sure if this script is still recommended to use as it's not been modified in nearly a decade. 1. Modified the `useradd` command by removing the `-m` option to prevent unnecessary warnings about the home directory already existing. The creation of the home directory is managed separately in this script using Btrfs subvolumes. 2. Added a command to copy the standard skeleton files from `/etc/skel` to the new user's home directory, ensuring that new users receive the necessary setup files despite the custom home directory creation process with the `create-config` command. 3. Corrected the `chown` command syntax to use the more modern `:` separator between the user and group names, getting rid of another warning. I kept the (old school) style as is. Thanks for snapper!
|
The script is likely bare used (esp. with the DRYRUN=1 setting). Anyway, I still get a warning about the home directory already existing unless I add -M. Likely you do not have "CREATE_HOME yes" in login.defs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this script is still recommended to use as it's not been modified in nearly a decade.
Modified the
useraddcommand by removing the-moption to prevent unnecessary warnings about the home directory already existing. The creation of the home directory is managed separately in this script using Btrfs subvolumes.Added a command to copy the standard skeleton files from
/etc/skelto the new user's home directory, ensuring that new users receive the necessary setup files despite the custom home directory creation process with thecreate-configcommand.Corrected the
chowncommand syntax to use the more modern:separator between the user and group names, getting rid of another warning.I kept the (old school) style as is. Thanks for snapper!