libmultipath: tur: protect pthread_cond_timedwait with a loop

Defect reported by coverity (413383 Data race condition) Signed-off-by: Martin Wilck <[email protected]> Reviewed-by: Benjamin Marzinski <[email protected]>
openSUSE · Jan 9, 2024 · 5a9476f · 5a9476f
1 parent 4e47bd1
commit 5a9476f
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/libmultipath/checkers/tur.c b/libmultipath/checkers/tur.c
@@ -438,9 +438,12 @@ int libcheck_check(struct checker * c)
 		}
 		tur_timeout(&tsp);
 		pthread_mutex_lock(&ct->lock);
-		if (ct->state == PATH_PENDING && ct->msgid == MSG_TUR_RUNNING)
-			r = pthread_cond_timedwait(&ct->active, &ct->lock,
-						   &tsp);
+
+		for (r = 0;
+		     r == 0 && ct->state == PATH_PENDING &&
+			     ct->msgid == MSG_TUR_RUNNING;
+		     r = pthread_cond_timedwait(&ct->active, &ct->lock, &tsp));
+
 		if (!r) {
 			tur_status = ct->state;
 			c->msgid = ct->msgid;