Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partitioning container #43

Merged
merged 22 commits into from
Aug 18, 2023
Merged

Partitioning container #43

merged 22 commits into from
Aug 18, 2023

Conversation

DannyJiang1
Copy link
Collaborator

No description provided.

@DannyJiang1
Added example code for partitioning a disk. TODO: Add in the option t…
d86d299 
…o input percentage as a unit
@DannyJiang1
Updated Dockerfile and created the entrypoint bash script
d45ce46
@DannyJiang1
deleted unnecessary files used for debugging
b090a6f
@DannyJiang1
Added some comments to the python files
b647f12
@DannyJiang1
Separated inputScript.bash into inputScript.sh, interactive.sh, and k…
7d734a9 
…ernelInput.py. The script will first check the kernel cmdline in /proc/cmdline for any input for partitioning. If that is not found, it then checks to see if there is a second argument (which will be passed in through the the iguana workflow file. If non specified then run the interactive mode
@DannyJiang1
Adjusted the way to take input slightly, made small optimizations to …
754b7be 
…reduce code redundancy.
@DannyJiang1
Edited Dockerfile so that the image can be built using osc
0be2360
@DannyJiang1
Uncommented python3 lines
3f5cfd5
@DannyJiang1
Added yaml workflow file
a1b7323
@DannyJiang1
renamed agama.yaml to partitioner.yaml
eab9f3f
@DannyJiang1
Edited Dockerfile to copy the files to a different location instead o…
cf3a0f1 
…f /iguana
@DannyJiang1
Edited workflow file to change the input file path from /iguana to /p…
dfe65cd 
…artition
@DannyJiang1
typo
485a9b9
@DannyJiang1
Added helper functions for commiting the storage to the hardware
cea7db7
@DannyJiang1
debuging for commiting
07eddc6
@DannyJiang1
Editing code (now probes) so that commit works
7b5d034
@DannyJiang1
Updated code so that the specified partition type will actually be ap…
a771014 
…plied after running the program.
@DannyJiang1
Added documentation README.
f53ad3f
aaannz
aaannz reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I have some feedback regarding unneeded comments.

Also in README, can you add new lines before headers so it is better readable even when not rendered?

examples/partitionContainer/partition.py Outdated Show resolved Hide resolved
examples/partitionContainer/interactive.sh Outdated Show resolved Hide resolved
examples/partitionContainer/inputScript.sh Outdated Show resolved Hide resolved
examples/partitionContainer/README.md Outdated Show resolved Hide resolved
aaannz
aaannz approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DannyJiang1 DannyJiang1 merged commit 505cc17 into main Aug 18, 2023
2 checks passed
@DannyJiang1 DannyJiang1 deleted the partitioningContainer branch August 18, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaannz aaannz aaannz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DannyJiang1 @aaannz