Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #396 warning when reading particle data #398

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Close #396 warning when reading particle data #398

merged 2 commits into from
Oct 4, 2023

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Oct 4, 2023 •
edited by ax3l
Loading

This implements the solution discussed in #396.

Close #396

@RemiLehe
Copy link
Member Author

RemiLehe commented Oct 4, 2023

I checked that this removes the warning, with the sample file posted in #396.

@ax3l ax3l self-requested a review October 4, 2023 20:19
@ax3l ax3l self-assigned this Oct 4, 2023
@ax3l ax3l added the warning label Oct 4, 2023
ax3l
ax3l approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

I added a small simplification.

@ax3l ax3l merged commit 88ab6e1 into openPMD:dev Oct 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
warning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning when reading particle data
2 participants
@RemiLehe @ax3l