Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_data for weighting in momentum reader #393

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

PrometheusPi
Copy link
Member

In case of the ED-PIC extension, momentum values need to take into account the weighting. This failed for ADIOS/openPMD-api data - see issue #391.
The reason for that was a missing argument in getData( ). This pull request fixes this issue.

cc'ing @ax3l @cbontoiu

@PrometheusPi
Copy link
Member Author

@RemiLehe and @ax3l I am not sure what causes the CI to fail. Error message just reads some http time out. Might be not related to this pull request.

@RemiLehe RemiLehe merged commit f6140de into openPMD:dev Sep 25, 2023
7 checks passed
@ax3l
Copy link
Member

ax3l commented Sep 25, 2023

Thank you for the fix!

@ax3l ax3l added the bug label Sep 25, 2023
@PrometheusPi PrometheusPi deleted the fix_openPMD_uxyz_weighting branch September 26, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants