Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading of 'rt' lasy files #371

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Support reading of 'rt' lasy files #371

merged 3 commits into from
Oct 12, 2023

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented May 17, 2023 •
edited
Loading

This PR provides a very rudimentary way to support some functionalities in visualizing lasy files.

(Technically speaking, lasy files do not conform to the openPMD 1.0 standard, since they sometimes use t as one of the axes.)

@RemiLehe RemiLehe changed the title [WIP] Support reading of ' [WIP] Support reading of 'rt' lasy files May 17, 2023
@ax3l ax3l added the feature label May 19, 2023
MaxThevenet
MaxThevenet reviewed May 19, 2023
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirm that this allowed me to read a cylindrical laser file generated by LASY (which did not work on dev.

@ax3l
Copy link
Member

ax3l commented Aug 9, 2023

@RemiLehe please needs a slight rebase

@RemiLehe RemiLehe changed the title [WIP] Support reading of 'rt' lasy files Support reading of 'rt' lasy files Oct 11, 2023
ax3l
ax3l approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ax3l ax3l self-assigned this Oct 12, 2023
@ax3l ax3l merged commit b36dc43 into openPMD:dev Oct 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet MaxThevenet left review comments

@ax3l ax3l ax3l approved these changes

@RTSandberg RTSandberg Awaiting requested review from RTSandberg

Assignees

@ax3l ax3l

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RemiLehe @ax3l @MaxThevenet