Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Stop supporting ipywidgets 4 #210

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions opmd_viewer/openpmd_timeseries/interactive.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ def slider(self, figsize=(6, 5), fields_figure=0, particles_figure=1,
if not dependencies_installed:
raise RuntimeError("Failed to load the openPMD-viewer slider.\n"
"(Make sure that ipywidgets and matplotlib are installed.)")
elif ipywidgets_version <= 4:
raise RuntimeError(
'Your version of ipywidgets is too old.\n'
'Please install a newer version of ipywidgets.\n'
'e.g. with: pip install --upgrade ipywidgets\n'
'or with: conda install -c conda-forge ipywidgets')

# -----------------------
# Define useful functions
Expand Down Expand Up @@ -572,22 +578,12 @@ def to_container( self ):
# Gather the different widgets on two lines
cmap_container = widgets.HBox( children=[
widgets.HTML( "<b>Colorbar:</b>"), self.cmap ])
if ipywidgets_version > 4:
# For newer version of ipywidgets: add the "x10^" on same line
range_container = widgets.HBox( children=[ self.active,
add_description("from", self.low_bound, width=30 ),
add_description("to", self.up_bound, width=20 ),
add_description("x 10^", self.exponent, width=45 ) ] )
final_container = widgets.VBox(
children=[ cmap_container, range_container ])
else:
# For older version of ipywidgets: add the "x10^" on new line
range_container = widgets.HBox( children=[ self.active,
add_description("from", self.low_bound, width=30 ),
add_description("to", self.up_bound, width=20 ) ] )
final_container = widgets.VBox(
children=[ cmap_container, range_container,
add_description("x 10^", self.exponent, width=45 ) ])
range_container = widgets.HBox( children=[ self.active,
add_description("from", self.low_bound, width=30 ),
add_description("to", self.up_bound, width=20 ),
add_description("x 10^", self.exponent, width=45 ) ] )
final_container = widgets.VBox(
children=[ cmap_container, range_container ])
set_widget_dimensions( final_container, width=310 )
return( final_container )

Expand Down