Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish between W+ and W- in particle type #288

Open
wants to merge 1 commit into
base: upcoming-2.0.0
Choose a base branch
from

Conversation

BrianMarre
Copy link

@BrianMarre BrianMarre commented Jul 26, 2024

distinguish between W+ and W- boson in particle type extension

Implements issue: #287

Description

Replaces the particle type w-boson with w-plus-boson and w-minus-boson in the particle type extension of openPMD.

This makes it possible to distinguish the differing electric charges of W+ and W- bosons and aligns them with the rest of particles.

Affected Components

  • EXT-SpeciesType

Logic Changes

non

Writer Changes

separate between W+ and W- bosons

Reader Changes

remove one SpeciesType and add two new SpeciesType

Data Converter

change speciesType from w-boson to either w-plus-boson or w-minus-boson
2.0 is not yet released, so no change needed from 1.X.

@ax3l ax3l added the EXT: SpeciesType physical particle species extension label Aug 5, 2024
@ax3l ax3l modified the milestones: openPMD 1.X, openPMD 2.X Aug 5, 2024
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that looks good to me.

Copy link
Collaborator

@DavidSagan DavidSagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EXT: SpeciesType physical particle species extension
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants