Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHEE-386,373 Update circle CI config of with integration test and host charts #126

Merged
merged 21 commits into from
Sep 1, 2023

Conversation

dhruvsonagara
Copy link
Contributor

@dhruvsonagara dhruvsonagara commented Aug 11, 2023

Description

PHEE-386 Update circle CI config of micro services with integration test
PHEE-373 build & host ph-ee-engine chart, g2p-sandbox chart and G2P sand…

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Design related bullet points or design document link related to this PR added in the description above.

  • Updated corresponding Postman Collection or Api documentation for the changes in this PR.

  • Create/update unit or integration tests for verifying the changes made.

  • Add required Swagger annotation and update API documentation with details of any API changes if applicable

  • Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing

@dhruvsonagara dhruvsonagara changed the title Hosting PHEE-386,373 Update circle CI config of with integration test and host charts Aug 11, 2023
@arkadasfynarfin
Copy link
Contributor

@dhruvsonagara Looks good to me.
CC: @fynmanoj

Copy link
Contributor

@fynmanoj fynmanoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check circle ci orn creation and may be try to avoid these code duplications?

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@fynmanoj fynmanoj merged commit 7ee2c1c into openMF:master Sep 1, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants