Improved security of password Textfields

openMF · Mar 23, 2024 · 319dd87 · 319dd87
1 parent 1dda11b
commit 319dd87
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/app/src/main/java/org/mifos/mobile/ui/login/LoginScreen.kt b/app/src/main/java/org/mifos/mobile/ui/login/LoginScreen.kt
@@ -37,6 +37,7 @@ import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.input.pointer.pointerInput
 import androidx.compose.ui.platform.LocalSoftwareKeyboardController
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.text.input.KeyboardType
 import androidx.compose.ui.text.input.PasswordVisualTransformation
 import androidx.compose.ui.text.input.TextFieldValue
 import androidx.compose.ui.text.input.VisualTransformation
@@ -130,7 +131,8 @@ fun LoginScreen(
                 }
             },
             error = passwordError,
-            supportingText = passwordErrorContent
+            supportingText = passwordErrorContent,
+            keyboardType = KeyboardType.Password
         )
 
         Spacer(modifier = Modifier.height(8.dp))

diff --git a/app/src/main/java/org/mifos/mobile/ui/registration/RegistrationScreen.kt b/app/src/main/java/org/mifos/mobile/ui/registration/RegistrationScreen.kt
@@ -35,6 +35,7 @@ import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.input.pointer.pointerInput
 import androidx.compose.ui.platform.LocalSoftwareKeyboardController
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.text.input.KeyboardType
 import androidx.compose.ui.text.input.PasswordVisualTransformation
 import androidx.compose.ui.text.input.TextFieldValue
 import androidx.compose.ui.text.input.VisualTransformation
@@ -178,7 +179,8 @@ fun RegistrationScreen(
                 IconButton(onClick = { passwordVisibility = !passwordVisibility }) {
                     Icon(imageVector = image, null)
                 }
-            }
+            },
+            keyboardType = KeyboardType.Password
         )
 
         if (onValueChangePassword) {
@@ -210,7 +212,8 @@ fun RegistrationScreen(
                 IconButton(onClick = { confirmPasswordVisibility = !confirmPasswordVisibility }) {
                     Icon(imageVector = image, null)
                 }
-            }
+            },
+            keyboardType = KeyboardType.Password
         )
 
         Row(

diff --git a/ui/src/main/java/org/mifos/mobile/core/ui/component/MifosOutlinedTextField.kt b/ui/src/main/java/org/mifos/mobile/core/ui/component/MifosOutlinedTextField.kt
@@ -21,6 +21,7 @@ import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.TextStyle
 import androidx.compose.ui.text.input.ImeAction
+import androidx.compose.ui.text.input.KeyboardType
 import androidx.compose.ui.text.input.TextFieldValue
 import androidx.compose.ui.text.input.VisualTransformation
 import androidx.compose.ui.unit.dp
@@ -38,7 +39,8 @@ fun MifosOutlinedTextField(
     visualTransformation: VisualTransformation = VisualTransformation.None,
     trailingIcon: @Composable (() -> Unit)? = null,
     error: Boolean = false,
-    supportingText: String
+    supportingText: String,
+    keyboardType: KeyboardType = KeyboardType.Text
 ) {
 
     OutlinedTextField(
@@ -70,7 +72,10 @@ fun MifosOutlinedTextField(
         textStyle = LocalDensity.current.run {
             TextStyle(fontSize = 18.sp)
         },
-        keyboardOptions = KeyboardOptions(imeAction = ImeAction.Next),
+        keyboardOptions = KeyboardOptions(
+            imeAction = ImeAction.Next,
+            keyboardType = keyboardType
+            ),
         visualTransformation = visualTransformation,
         isError = error,
         supportingText = {