Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:added ABI filters to reduce APK size #220

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ivary43
Copy link

@ivary43 ivary43 commented Apr 2, 2018

Please make sure these boxes are checked before submitting your pull request - thanks!

Fixes #214

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@ivary43
Copy link
Author

ivary43 commented Apr 2, 2018

@therajanmaurya please review.

@ivary43 ivary43 force-pushed the Issue#214 branch 2 times, most recently from fc780ac to 00d6d0d Compare April 2, 2018 17:17
@miPlodder
Copy link

@ivary43 I guess currently this application does not contain any Native Library, so adding ABI Filters wouldn't decrease the APK size.

@ivary43
Copy link
Author

ivary43 commented May 14, 2018

@miPlodder I didn't get you why it wouldn't, this is ABI split for various CPU architecture.

@miPlodder
Copy link

@ivary43 ABI Split will create different APKs for different Architecture. But what's the point of creating multiple APK's, if all of them are equivalent. We used it in other project (like https://github.com/openMF/mifos-mobile/tree/development/app/src/main/jniLibs) because we have a Native Encryption Library as dependency. In that case, it would make sense because creating 1 APK and having multiple Architecture dependency, although the device using that APK will have only 1 Architecture and will used that dependency only. Hence, other Native Libraries are increasing the APK size and splitting the APK on basis on Architecture will be beneficial, which is not true for this Project as of now since it doesn't contain any Native Dependency.

@ivary43
Copy link
Author

ivary43 commented May 14, 2018

Oh yeah sorry, I totally forgot there is no passcode feature so they don't have to encrypt the password and save it, I mistakenly assumed these are all present and didn't check for the .so files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants