Expanded content for DV_TEXT, DV_CODED_TEXT and DV_QUANTITY to match … #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolandscat
reviewed
Aug 31, 2020
| "a/b/c/d|precision": 1, | ||
| "a/b/c/d|normal_status": "H", | ||
| "a/b/c/d|magnitude_status": "~", | ||
| "a/b/c/d/_normal_range/lower|magnitude": 2.5, |
There was a problem hiding this comment.
Why does _normal_range start with an '_' here? Isn't normal_range just a normal attribute of a DV_ORDERED?
There was a problem hiding this comment.
My understanding is that the underscore is used on a few RM attributes to avoid potential naming collisions with archetyped nodes e.g it might be the case that a potential archetype node is called 'normal status' and gets compressed to 'normal_status'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…current Better formats. I would suggest retaining the | marker on leaf nodes for now, to preserve backward compatibility. It may also assist conversion between the Path and Regular structures. Now working on COUNT, NULL, and ORDINAL