Fix parser/lexer ambiguity for CONTAINS function #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the grammar does not properly accept this scenario:
This is caused by ANTLR recognizing the
CONTAINS
function call in theSELECT
clause as aCONTAINS
instead of aSTRING_FUNCTION_ID
, asCONTAINS
is defined earlier in the lexer.The 'reuse' of non-fragment lexer symbols in this way is not really supported by ANTLR without resorting to rather complicated solutions, so I suggest just extending the definition of the
functionCall
parser rule a little, as this PR does.